all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH series/flutter 0/4] fixes related to PVE 7
Date: Wed, 23 Jun 2021 13:36:18 +0200	[thread overview]
Message-ID: <3b796e75-9cd9-6074-a289-766c42cf7ea8@proxmox.com> (raw)
In-Reply-To: <20210623100444.1440650-1-a.lauterer@proxmox.com>

On 23.06.21 12:04, Aaron Lauterer wrote:
> This series contains a few fixes for problems that I came across when
> testing the flutter app against Proxmox VE 7.
> 
> The first bigger one, affecting the first 3 patches, is handling of
> different types when parsing API responses. The PVE API is not always
> returning the expected type. In most situations it is numbers formatted
> as strings instead of numbers.
> 
> For dynamically types languages this is usually much less of a problem
> as it is in statically typed languages as dart.
> To handle that, I introduced new custom serializers for Strings,
> integers and doubles. If the value is not of the expected type, they
> should be able to handle situations where the number is formatted as
> string or where the expected string is formatted as number and
> cast/parse them accordingly.
> 
> The last patch addresses a problem that showed up when trying to open
> the power menu for a guest that had been powered off. The handling of
> the states template value being null has not been done correctly. I used
> the same approach as throughout the other parts where the template
> status is checked -> falling back to false.
> 
> dart_api_client: Aaron Lauterer (3):
>   Add string serializer to handle int and double values
>   Add int serializer to handle string values
>   Add double serializer to handle String and int values
> 
>  lib/src/models/pve_double_serializer.dart | 28 +++++++++++++++++++++++
>  lib/src/models/pve_int_serializer.dart    | 25 ++++++++++++++++++++
>  lib/src/models/pve_string_serializer.dart | 25 ++++++++++++++++++++
>  lib/src/models/serializers.dart           |  6 +++++
>  4 files changed, 84 insertions(+)
>  create mode 100644 lib/src/models/pve_double_serializer.dart
>  create mode 100644 lib/src/models/pve_int_serializer.dart
>  create mode 100644 lib/src/models/pve_string_serializer.dart
> 
> flutter_frontend: Aaron Lauterer (1):
>   power settings: fix handling null for template status
> 
>  lib/widgets/pve_qemu_power_settings_widget.dart | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 



applied series, thanks!




      parent reply	other threads:[~2021-06-23 11:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 10:04 [pve-devel] " Aaron Lauterer
2021-06-23 10:04 ` [pve-devel] [PATCH dart_api_client 1/4] Add string serializer to handle int and double values Aaron Lauterer
2021-06-23 10:04 ` [pve-devel] [PATCH dart_api_client 2/4] Add int serializer to handle string values Aaron Lauterer
2021-06-23 10:04 ` [pve-devel] [PATCH dart_api_client 3/4] Add double serializer to handle String and int values Aaron Lauterer
2021-06-23 10:04 ` [pve-devel] [PATCH flutter_frontend 4/4] power settings: fix handling null for template status Aaron Lauterer
2021-06-23 11:36 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b796e75-9cd9-6074-a289-766c42cf7ea8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal