all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api/pmg-docs v2] make filter timeout configurable
Date: Wed, 21 Feb 2024 15:35:07 +0100	[thread overview]
Message-ID: <3b72662a-993e-4348-b60b-a41e1bf79e8e@proxmox.com> (raw)
In-Reply-To: <20240112192151.40998-1-s.ivanov@proxmox.com>

Looked and tested this, and it does what it says on the tin.

My original concern still exists but that would require a much more
intrusive fix (that we can still do in the future):

when the sending/remaining processing of the mail (aka the actions)
take longer than what time we still have remaining, we have
the same behavior as the original problem.

a short example:

filter-timeout: x seconds
processing up to the check: y seconds (but smaller than x)

if now the actions take more than 'x - y' seconds, the first
postfix instance runs into it's timeout, but the pmg-smtp-filter
is already processing the action (e.g. sending/quarantining)

To completely fix that, we'd have to (before the timeout check):
find out what actions would be taken,
return the postfix that status as if it was done
(e.g. accept/reject) (if that's even possible?)

and then do the actual action.
if that fails, we'd have to take an appropriate action,
e.g. send an ndr.

Aside from that, consider this series

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>




  parent reply	other threads:[~2024-02-21 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 19:21 Stoiko Ivanov
2024-01-12 19:21 ` [pmg-devel] [PATCH pmg-docs v2 1/1] doc-generator: add new option filter-timeout Stoiko Ivanov
2024-01-12 19:21 ` [pmg-devel] [PATCH pmg-api v2 1/4] templates: postfix: set same timeouts for before and after-queue Stoiko Ivanov
2024-01-12 19:21 ` [pmg-devel] [PATCH pmg-api v2 2/4] pmg-smtp-filter: cleanup use of gettimeofday Stoiko Ivanov
2024-01-12 19:21 ` [pmg-devel] [PATCH pmg-api v2 3/4] config: postfix: make smtp-filter-timeout configurable Stoiko Ivanov
2024-01-12 19:21 ` [pmg-devel] [PATCH pmg-api v2 4/4] pmg-smtp-filter: die if processing took longer than the timeout Stoiko Ivanov
2024-02-21 14:35 ` Dominik Csapak [this message]
2024-02-22 15:23 ` [pmg-devel] applied-series: [PATCH pmg-api/pmg-docs v2] make filter timeout configurable Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b72662a-993e-4348-b60b-a41e1bf79e8e@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal