all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager] server: remotes: add acls to PBS API token on token creation
Date: Fri, 26 Sep 2025 11:56:19 +0200	[thread overview]
Message-ID: <3b26e286-a18d-48dc-8378-89cb5469720a@proxmox.com> (raw)
In-Reply-To: <20250926063312.27000-1-c.ebner@proxmox.com>

Am 26.09.25 um 08:33 schrieb Christian Ebner:
> PBS requires the token to have a role for a given ACL path to allow
> access to the corresponding sub-resource. In order to provide the
> token created by the remote add wizard the necessary permissions,
> adapt the client code so it also performs the additional API calls.
> 
> Adapt the internal API such that there is additional type checking
> instead of using plain strings and extend it such that multiple acls
> can be set if required, to be future prove.

As discussed off list, this was replaced by a similar implementation
I had already prepared locally [0], it differs mostly in:

- setting the admin role to /, not just a audit role, which is not
  that useful for the PDM, that way it's also closer to what PVE
  does through disabling privilege separation completely (not available
  for PBS).

- use an actual type not a serde json Value assembled on the fly.

Thanks nonetheless, this was also helpful to me to cross-check.

[0]; https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=commitdiff;h=4369771b00173048666c269749c0a61faff83352




_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      reply	other threads:[~2025-09-26  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26  6:33 Christian Ebner
2025-09-26  9:56 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b26e286-a18d-48dc-8378-89cb5469720a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal