* [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports
@ 2025-12-16 16:05 Stefan Hanreich
2025-12-16 16:17 ` Stefan Hanreich
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Stefan Hanreich @ 2025-12-16 16:05 UTC (permalink / raw)
To: pve-devel
The new check did not consider bonds, since ip_link_is_physical only
returns true for physical interfaces - but not bonds. Add a new
function to check for bonds explicitly and use it when checking for
bridge ports in activate_bridge_vlan.
This bug caused VMs with network devices with VLAN tags, on
non-vlan-aware bridges, to not get started / migrated.
Fixes: 057f62f7
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
Changes from v1:
* improved commit message
* add missing definedness check
src/PVE/IPRoute2.pm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/PVE/IPRoute2.pm b/src/PVE/IPRoute2.pm
index 5208d93..c60a91d 100644
--- a/src/PVE/IPRoute2.pm
+++ b/src/PVE/IPRoute2.pm
@@ -32,6 +32,14 @@ sub ip_link_is_physical($ip_link) {
&& (!defined($ip_link->{linkinfo}) || !defined($ip_link->{linkinfo}->{info_kind}));
}
+sub ip_link_is_bond($ip_link) {
+ return
+ $ip_link->{link_type} eq 'ether'
+ && defined($ip_link->{linkinfo})
+ && defined($ip_link->{linkinfo}->{info_kind})
+ && $ip_link->{linkinfo}->{info_kind} eq 'bond';
+}
+
sub ip_link_is_bridge($ip_link) {
return
defined($ip_link->{linkinfo})
@@ -67,7 +75,8 @@ sub get_physical_bridge_ports($bridge, $ip_links = undef) {
}
return grep {
- ip_link_is_physical($ip_links->{$_}) && $ip_links->{$_}->{master} eq $bridge
+ (ip_link_is_physical($ip_links->{$_}) || ip_link_is_bond($ip_links->{$_}))
+ && defined($ip_links->{$_}->{master}) && $ip_links->{$_}->{master} eq $bridge
} keys $ip_links->%*;
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports
2025-12-16 16:05 [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports Stefan Hanreich
@ 2025-12-16 16:17 ` Stefan Hanreich
2025-12-17 14:30 ` Stoiko Ivanov
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hanreich @ 2025-12-16 16:17 UTC (permalink / raw)
To: pve-devel
tested by a user in the forum:
https://forum.proxmox.com/threads/problem-migrating-vms-in-a-proxmox-9-cluster-with-vlan-on-vmbr0.177334/#post-825321
On 12/16/25 5:05 PM, Stefan Hanreich wrote:
> The new check did not consider bonds, since ip_link_is_physical only
> returns true for physical interfaces - but not bonds. Add a new
> function to check for bonds explicitly and use it when checking for
> bridge ports in activate_bridge_vlan.
>
> This bug caused VMs with network devices with VLAN tags, on
> non-vlan-aware bridges, to not get started / migrated.
>
> Fixes: 057f62f7
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> Changes from v1:
> * improved commit message
> * add missing definedness check
>
> src/PVE/IPRoute2.pm | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/IPRoute2.pm b/src/PVE/IPRoute2.pm
> index 5208d93..c60a91d 100644
> --- a/src/PVE/IPRoute2.pm
> +++ b/src/PVE/IPRoute2.pm
> @@ -32,6 +32,14 @@ sub ip_link_is_physical($ip_link) {
> && (!defined($ip_link->{linkinfo}) || !defined($ip_link->{linkinfo}->{info_kind}));
> }
>
> +sub ip_link_is_bond($ip_link) {
> + return
> + $ip_link->{link_type} eq 'ether'
> + && defined($ip_link->{linkinfo})
> + && defined($ip_link->{linkinfo}->{info_kind})
> + && $ip_link->{linkinfo}->{info_kind} eq 'bond';
> +}
> +
> sub ip_link_is_bridge($ip_link) {
> return
> defined($ip_link->{linkinfo})
> @@ -67,7 +75,8 @@ sub get_physical_bridge_ports($bridge, $ip_links = undef) {
> }
>
> return grep {
> - ip_link_is_physical($ip_links->{$_}) && $ip_links->{$_}->{master} eq $bridge
> + (ip_link_is_physical($ip_links->{$_}) || ip_link_is_bond($ip_links->{$_}))
> + && defined($ip_links->{$_}->{master}) && $ip_links->{$_}->{master} eq $bridge
> } keys $ip_links->%*;
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports
2025-12-16 16:05 [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports Stefan Hanreich
2025-12-16 16:17 ` Stefan Hanreich
@ 2025-12-17 14:30 ` Stoiko Ivanov
2025-12-17 17:26 ` Stefan Hanreich
2025-12-17 21:27 ` [pve-devel] applied: " Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Stoiko Ivanov @ 2025-12-17 14:30 UTC (permalink / raw)
To: Stefan Hanreich; +Cc: Proxmox VE development discussion
As I ran into this issue today - I took the time to check this out a bit
closer.
It fixes the issue of bond's vanishing from the bridge behind a vlan-vnet
on a non-vlan-aware bridge.
one opinionated nit inline:
On Tue, 16 Dec 2025 17:05:10 +0100
Stefan Hanreich <s.hanreich@proxmox.com> wrote:
> The new check did not consider bonds, since ip_link_is_physical only
> returns true for physical interfaces - but not bonds. Add a new
> function to check for bonds explicitly and use it when checking for
> bridge ports in activate_bridge_vlan.
>
> This bug caused VMs with network devices with VLAN tags, on
> non-vlan-aware bridges, to not get started / migrated.
>
> Fixes: 057f62f7
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> Changes from v1:
> * improved commit message
> * add missing definedness check
>
> src/PVE/IPRoute2.pm | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/IPRoute2.pm b/src/PVE/IPRoute2.pm
> index 5208d93..c60a91d 100644
> --- a/src/PVE/IPRoute2.pm
> +++ b/src/PVE/IPRoute2.pm
> @@ -32,6 +32,14 @@ sub ip_link_is_physical($ip_link) {
> && (!defined($ip_link->{linkinfo}) || !defined($ip_link->{linkinfo}->{info_kind}));
> }
>
> +sub ip_link_is_bond($ip_link) {
> + return
> + $ip_link->{link_type} eq 'ether'
> + && defined($ip_link->{linkinfo})
> + && defined($ip_link->{linkinfo}->{info_kind})
> + && $ip_link->{linkinfo}->{info_kind} eq 'bond';
> +}
> +
> sub ip_link_is_bridge($ip_link) {
> return
> defined($ip_link->{linkinfo})
> @@ -67,7 +75,8 @@ sub get_physical_bridge_ports($bridge, $ip_links = undef) {
> }
not sure if a bond is a "physical" bridge-port, and not sure if this might
cause confusion in the future - maybe non_guest_bridge_port?,
egress_bridge_port?
but as it's just a cosmetic fix (if an improvement at all)- the patch as is
is fine! consider this:
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
>
> return grep {
> - ip_link_is_physical($ip_links->{$_}) && $ip_links->{$_}->{master} eq $bridge
> + (ip_link_is_physical($ip_links->{$_}) || ip_link_is_bond($ip_links->{$_}))
> + && defined($ip_links->{$_}->{master}) && $ip_links->{$_}->{master} eq $bridge
> } keys $ip_links->%*;
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports
2025-12-16 16:05 [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports Stefan Hanreich
2025-12-16 16:17 ` Stefan Hanreich
2025-12-17 14:30 ` Stoiko Ivanov
@ 2025-12-17 17:26 ` Stefan Hanreich
2025-12-17 21:27 ` [pve-devel] applied: " Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hanreich @ 2025-12-17 17:26 UTC (permalink / raw)
To: pve-devel
quite a few people running into this issue in the forums / support
already :/
would be nice to have this at least on test soon?
On 12/16/25 5:05 PM, Stefan Hanreich wrote:
> The new check did not consider bonds, since ip_link_is_physical only
> returns true for physical interfaces - but not bonds. Add a new
> function to check for bonds explicitly and use it when checking for
> bridge ports in activate_bridge_vlan.
>
> This bug caused VMs with network devices with VLAN tags, on
> non-vlan-aware bridges, to not get started / migrated.
>
> Fixes: 057f62f7
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> Changes from v1:
> * improved commit message
> * add missing definedness check
>
> src/PVE/IPRoute2.pm | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/IPRoute2.pm b/src/PVE/IPRoute2.pm
> index 5208d93..c60a91d 100644
> --- a/src/PVE/IPRoute2.pm
> +++ b/src/PVE/IPRoute2.pm
> @@ -32,6 +32,14 @@ sub ip_link_is_physical($ip_link) {
> && (!defined($ip_link->{linkinfo}) || !defined($ip_link->{linkinfo}->{info_kind}));
> }
>
> +sub ip_link_is_bond($ip_link) {
> + return
> + $ip_link->{link_type} eq 'ether'
> + && defined($ip_link->{linkinfo})
> + && defined($ip_link->{linkinfo}->{info_kind})
> + && $ip_link->{linkinfo}->{info_kind} eq 'bond';
> +}
> +
> sub ip_link_is_bridge($ip_link) {
> return
> defined($ip_link->{linkinfo})
> @@ -67,7 +75,8 @@ sub get_physical_bridge_ports($bridge, $ip_links = undef) {
> }
>
> return grep {
> - ip_link_is_physical($ip_links->{$_}) && $ip_links->{$_}->{master} eq $bridge
> + (ip_link_is_physical($ip_links->{$_}) || ip_link_is_bond($ip_links->{$_}))
> + && defined($ip_links->{$_}->{master}) && $ip_links->{$_}->{master} eq $bridge
> } keys $ip_links->%*;
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] applied: [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports
2025-12-16 16:05 [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports Stefan Hanreich
` (2 preceding siblings ...)
2025-12-17 17:26 ` Stefan Hanreich
@ 2025-12-17 21:27 ` Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2025-12-17 21:27 UTC (permalink / raw)
To: pve-devel, Stefan Hanreich
On Tue, 16 Dec 2025 17:05:10 +0100, Stefan Hanreich wrote:
> The new check did not consider bonds, since ip_link_is_physical only
> returns true for physical interfaces - but not bonds. Add a new
> function to check for bonds explicitly and use it when checking for
> bridge ports in activate_bridge_vlan.
>
> This bug caused VMs with network devices with VLAN tags, on
> non-vlan-aware bridges, to not get started / migrated.
>
> [...]
Applied, thanks!
[1/1] fix #7153: iproute2: consider bonds as physical bridge ports
commit: 8516622423e11789ef2801bd44f58803544eafab
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-17 21:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-16 16:05 [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports Stefan Hanreich
2025-12-16 16:17 ` Stefan Hanreich
2025-12-17 14:30 ` Stoiko Ivanov
2025-12-17 17:26 ` Stefan Hanreich
2025-12-17 21:27 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.