From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit 1/2] api-viewer: fix #4271: display nested formats instead of [object Object]
Date: Thu, 17 Nov 2022 08:30:02 +0100 [thread overview]
Message-ID: <39cd0854-311d-bd85-5ff2-c561e777385e@proxmox.com> (raw)
In-Reply-To: <20221012132332.301805-1-m.heiserer@proxmox.com>
Am 12/10/2022 um 15:23 schrieb Matthias Heiserer:
> I tried to keep the format as close to the HTML docs as possible, but there are a few discrepancies between HTML docs and how this patch displays parameters:
> Instead of <enum>,the enum variants are displayed. [1]
> Instead of <0|1>, <boolean> is displayed.
>
> [1] The HTML docs explain parameters after the initial format string, which the GUI doesn't (and there's no space for that).
> Showing the variants inline is the easiest way to not loose information here.
please use a text-width limit of <<70 for commit message text:
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
I re-wrapped that on apply.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> src/api-viewer/APIViewer.js | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-11-17 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 13:23 [pve-devel] " Matthias Heiserer
2022-10-12 13:23 ` [pve-devel] [PATCH widget-toolkit 2/2] show min/max for values without any other format Matthias Heiserer
2022-11-17 7:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39cd0854-311d-bd85-5ff2-c561e777385e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.