Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting

[Dominik Csapak <d.csapak@proxmox.com>]

sadly removing these parameters would be a breaking change

i'd rather mark it deprecatedand non-functional in the description
and remove the functionality

then on the next major release, we can announce the breaking change and
remove the parameter

On 9/7/23 11:49, Maximiliano Sandoval wrote:
> This setting was removed in [1] as part of the v13.0.2 tag.
> 
> [1] https://github.com/ceph/ceph/commit/e6acf2d1d528a2395947d446a57bec04a3a002dc
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> I did a grep search across multiple projects and I was not able to find
> more uses of this option. A second pair of eyes might help here.
> 
>   PVE/API2/Ceph.pm | 15 ---------------
>   1 file changed, 15 deletions(-)
> 
> diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
> index 7e0763cf..a4101dee 100644
> --- a/PVE/API2/Ceph.pm
> +++ b/PVE/API2/Ceph.pm
> @@ -158,16 +158,6 @@ __PACKAGE__->register_method ({
>   		minimum => 1,
>   		maximum => 7,
>   	    },
> -	    pg_bits => {
> -		description => "Placement group bits, used to specify the " .
> -		    "default number of placement groups.\n\nNOTE: 'osd pool " .
> -		    "default pg num' does not work for default pools.",
> -		type => 'integer',
> -		default => 6,
> -		optional => 1,
> -		minimum => 6,
> -		maximum => 14,
> -	    },
>   	    disable_cephx => {
>   		description => "Disable cephx authentication.\n\n" .
>   		    "WARNING: cephx is a security feature protecting against " .
> @@ -224,11 +214,6 @@ __PACKAGE__->register_method ({
>   		$cfg->{client}->{keyring} = '/etc/pve/priv/$cluster.$name.keyring';
>   	    }
>   
> -	    if ($param->{pg_bits}) {
> -		$cfg->{global}->{'osd pg bits'} = $param->{pg_bits};
> -		$cfg->{global}->{'osd pgp bits'} = $param->{pg_bits};
> -	    }
> -
>   	    if ($param->{network}) {
>   		$cfg->{global}->{'public network'} = $param->{network};
>   		$cfg->{global}->{'cluster network'} = $param->{network};