From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH cluster] ssh: default to 4096 bit keys when generating
Date: Fri, 22 Mar 2024 17:35:22 +0100 [thread overview]
Message-ID: <397f5b46-d5e1-4cb8-8bbc-23260297e5d0@proxmox.com> (raw)
In-Reply-To: <20231221094609.143784-1-f.gruenbichler@proxmox.com>
Am 21.12.23 um 10:46 schrieb Fabian Grünbichler:
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
by removing my existing ones, attempt to SSH to other node and fail
(just to be sure), running pvecm updatecerts and SSH-ing to other node
with new key.
> ---
> src/PVE/Cluster/Setup.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Cluster/Setup.pm b/src/PVE/Cluster/Setup.pm
> index 07020d7..4b12bb8 100644
> --- a/src/PVE/Cluster/Setup.pm
> +++ b/src/PVE/Cluster/Setup.pm
> @@ -157,7 +157,7 @@ sub setup_rootsshconfig {
> # create ssh key if it does not exist
> if (! -f $ssh_root_rsa_key_public) {
> mkdir '/root/.ssh/';
> - system ("echo|ssh-keygen -t rsa -N '' -b 2048 -f ${ssh_root_rsa_key_private}");
> + system ("echo|ssh-keygen -t rsa -N '' -b 4096 -f ${ssh_root_rsa_key_private}");
> }
>
> # create ssh config if it does not exist
next prev parent reply other threads:[~2024-03-22 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 9:46 Fabian Grünbichler
2024-03-22 16:35 ` Fiona Ebner [this message]
2024-03-25 7:46 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=397f5b46-d5e1-4cb8-8bbc-23260297e5d0@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.