Re: [pve-devel] [PATCH v3 pve-network 0/5] SDN: Add mocking to run tests in sbuild

[Stefan Hanreich <s.hanreich@proxmox.com>]

Tested building this with sbuild - completed successfully (including tests).

I've also checked out the changes and tested them by creating a new EVPN
zone and setting a local frr config. Everything still seems to be
working as before.

Consider this:

Tested-By: Stefan Hanreich <s.hanreich@proxmox.com>


On 4/2/24 13:07, Stefan Lendl wrote:
> Extract and mock functions that otherwise access system files which is not
> possible in a clean sbuild environment.
> Namely /etc/network/interfaces as well as /etc/frr/frr.config.local
> Added .gitignore for sbuild artifacts
> 
> Changes v2 -> v3:
> * Changed commit messages according to commit guide lines
> * Not importing Dumper in zones test
> * Re-Enabled DNS tests
> * Added .gitignore which was previously a separate patch
> 
> Changes v1 -> v2:
> * Disabled DNS tests because they fail
> 
> 
> Stefan Lendl (5):
>   controllers: extract read_etc_network_interfaces
>   evpn: extract read_local_frr_config
>   tests: mocking more functions to avoid system access
>   tests: run tests in sbuild
>   gitignore: build artifacts from sbuild
> 
>  .gitignore                                    |  3 ++
>  src/Makefile                                  |  2 +-
>  src/PVE/Network/SDN/Controllers.pm            | 16 +++++++---
>  src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 10 ++++--
>  src/test/run_test_zones.pl                    | 31 +++++++++++++++++++
>  5 files changed, 54 insertions(+), 8 deletions(-)
>