Re: [pve-devel] [PATCH manager v3 3/5] api/acme: deprecate tos endpoint in favor of meta

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 31/10/2023 um 10:05 schrieb Folke Gleumes:
> The ToS endpoint ignored data that is needed to detect if EAB needs to
> be used. Instead of adding a new endpoint that does the same request,
> the tos endpoint is deprecated and replaced by the meta endpoint,
> that returns all information returned by the directory.
> 
> Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
> ---
> No changes in v3
> 
>  PVE/API2/ACMEAccount.pm | 56 ++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 55 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2/ACMEAccount.pm
> index ec4eba24..bc45d5ab 100644
> --- a/PVE/API2/ACMEAccount.pm
> +++ b/PVE/API2/ACMEAccount.pm

> +    returns => {
> +	type => 'object',
> +	additionalProperties => 1,
> +	properties => {
> +	    termsOfService => {
> +		type => 'string',
> +		optional => 1,
> +		description => 'ACME TermsOfService URL.',

nit: we normally place the description at the top, and sometimes as
second item after "type", but at the bottom is rather unusual.

> +	    },
> +	    externalAccountRequired => {
> +		type => 'boolean',
> +		optional => 1,
> +		description => 'EAB Required'
> +	    },
> +	    website => {
> +		type => 'string',
> +		optional => 1,
> +		description => 'URL to more information about the ACME server.'
> +	    },
> +	    caaIdentities => {
> +		type => 'string',

but the RFC say's that this is an array, and we do not actually mangle this into
a plain string anywhere FWICT, checking the API response would agree on that too.

So, can you re-check and mark this as array in a follow-up?

> +		optional => 1,
> +		description => 'Hostnames referring to the ACME servers.'



> +	    },