From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] proxy: ui: vm console: autodetect novnc or xtermjs
Date: Mon, 25 Nov 2024 11:06:11 +0100 [thread overview]
Message-ID: <3836fe8a-784e-406b-8d47-34ff9ad35da3@proxmox.com> (raw)
In-Reply-To: <20241122143817.352143-1-a.lauterer@proxmox.com>
sent a v2:
https://lore.proxmox.com/pve-devel/20241125100427.86341-1-a.lauterer@proxmox.com/T/#u
On 2024-11-22 15:38, Aaron Lauterer wrote:
> Another thing that I noticed is that the property we use to decide if we
> enable xtermjs for VMs in the top right console button, and for now also
> in this patch, only checks if the VM has a serial device configured.
> PVE::QemuServer::vmstatus() calls `conf_has_serial()`.
>
> A better approach would be to have a vmstatus property that actually
> tells us if the VM has serial set as display option. As the display
> could be set to something else, even if a serial device exists. There
> are other use-cases for a serial device in the VM, like passing through
> an actual serial port.
>
> But I didn't want to open that can of worms just yet ;)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-25 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 14:38 Aaron Lauterer
2024-11-25 9:46 ` Daniel Herzig
2024-11-25 10:06 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3836fe8a-784e-406b-8d47-34ff9ad35da3@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.