all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>,
	yew-devel@lists.proxmox.com,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [PATCH proxmox-yew-comp 1/1] key value list: accept objects as data
Date: Wed, 27 May 2026 08:32:03 +0200	[thread overview]
Message-ID: <376e0b64-03ac-42fc-9e14-b2f8a6b9a780@proxmox.com> (raw)
In-Reply-To: <20260526164903.618112-1-s.hanreich@proxmox.com>

as it's already applied it does not matter for now, but
IMHO this is the wrong fix for the problem

Either the KVList assumes/accepts a list (vec<(string, value)>)
or it works with hashmap/btreemaps

it does not make sense really to enforce a list everywhere but
internally also accept a hashmap?

this will only cause confusion in the future when a user either
enters the same key twice (be it by accident or with intent)

or if someone needs to have multiple same keys in a different context.

Since the use-case for this for now seems to be only a hashmap,
I'd argue we should rework that widget so it works with hashmaps only

this could even improve the usability (e.g. checking if a key already 
exists)

if we do this we should rename it something appropriate e.g.
PropertyMap (suggestion by dietmar)

@Christoph, can you look at that after the release?
(Since you used it in the auto-installer ui part)
If not i can take a look too




      parent reply	other threads:[~2026-05-27  6:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 16:49 [PATCH proxmox-yew-comp 1/1] key value list: accept objects as data Stefan Hanreich
2026-05-26 20:47 ` applied: " Thomas Lamprecht
2026-05-27  6:32 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=376e0b64-03ac-42fc-9e14-b2f8a6b9a780@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=s.hanreich@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal