From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0ED241FF13A for ; Wed, 27 May 2026 08:32:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A1C3F107E6; Wed, 27 May 2026 08:32:42 +0200 (CEST) Message-ID: <376e0b64-03ac-42fc-9e14-b2f8a6b9a780@proxmox.com> Date: Wed, 27 May 2026 08:32:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-yew-comp 1/1] key value list: accept objects as data To: Stefan Hanreich , yew-devel@lists.proxmox.com, Christoph Heiss References: <20260526164903.618112-1-s.hanreich@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260526164903.618112-1-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779863502492 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5UAKPNL6T4AW7I34HN3VJ35IRFMODOJ3 X-Message-ID-Hash: 5UAKPNL6T4AW7I34HN3VJ35IRFMODOJ3 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: as it's already applied it does not matter for now, but IMHO this is the wrong fix for the problem Either the KVList assumes/accepts a list (vec<(string, value)>) or it works with hashmap/btreemaps it does not make sense really to enforce a list everywhere but internally also accept a hashmap? this will only cause confusion in the future when a user either enters the same key twice (be it by accident or with intent) or if someone needs to have multiple same keys in a different context. Since the use-case for this for now seems to be only a hashmap, I'd argue we should rework that widget so it works with hashmaps only this could even improve the usability (e.g. checking if a key already exists) if we do this we should rename it something appropriate e.g. PropertyMap (suggestion by dietmar) @Christoph, can you look at that after the release? (Since you used it in the auto-installer ui part) If not i can take a look too