Re: [PATCH cluster 2/2] fix #5475: configurable window title

[Dominik Csapak <d.csapak@proxmox.com>]

two comments inline

On 7/3/26 1:56 PM, Thomas Ellmenreich wrote:
> Added new configuration option that will determine the content
> of the window title for a pve-manager tab.
> 
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>   src/PVE/DataCenterConfig.pm | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 004122e..480193a 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -436,6 +436,13 @@ my $datacenter_schema = {
>               # FIXME: remove 'applet' with 9.0 (add pve8to9 check!)
>               enum => ['applet', 'vv', 'html5', 'xtermjs'],
>           },
> +        window_title => {

I think we prefer 'kebab-case' nowadays, so this should be:

'window-title'

> +            optional => 1,
> +            type => 'string',
> +            description =>
> +                "Define the text shown in the window title for all nodes of this cluster",
> +            enum => ['nodeandcluster', 'fqdn'],

also here we should probably use 'node-and-cluster'

> +        },
>           email_from => {
>               optional => 1,
>               type => 'string',