From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0D2E91FF12F for ; Tue, 14 Jul 2026 08:44:17 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F26DE213A7; Tue, 14 Jul 2026 08:44:15 +0200 (CEST) Message-ID: <3730bf70-a35c-4918-87f5-b045d4846f30@proxmox.com> Date: Tue, 14 Jul 2026 08:43:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH cluster 2/2] fix #5475: configurable window title To: Thomas Ellmenreich , pve-devel@lists.proxmox.com References: <20260703115530.106413-1-t.ellmenreich@proxmox.com> <20260703115530.106413-3-t.ellmenreich@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260703115530.106413-3-t.ellmenreich@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784011403198 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IZOCXXW2X2GEZ6Y2DBAATVFAC63WER74 X-Message-ID-Hash: IZOCXXW2X2GEZ6Y2DBAATVFAC63WER74 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: two comments inline On 7/3/26 1:56 PM, Thomas Ellmenreich wrote: > Added new configuration option that will determine the content > of the window title for a pve-manager tab. > > Signed-off-by: Thomas Ellmenreich > --- > src/PVE/DataCenterConfig.pm | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index 004122e..480193a 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -436,6 +436,13 @@ my $datacenter_schema = { > # FIXME: remove 'applet' with 9.0 (add pve8to9 check!) > enum => ['applet', 'vv', 'html5', 'xtermjs'], > }, > + window_title => { I think we prefer 'kebab-case' nowadays, so this should be: 'window-title' > + optional => 1, > + type => 'string', > + description => > + "Define the text shown in the window title for all nodes of this cluster", > + enum => ['nodeandcluster', 'fqdn'], also here we should probably use 'node-and-cluster' > + }, > email_from => { > optional => 1, > type => 'string',