[pve-devel] applied: [PATCH common] inotify: avoid cyclic use statement

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 02.08.24 um 13:53 schrieb Fiona Ebner:
> Commit e68ebda ("fix #545: interfaces: allow arbitrary bridge names in
> network config") introduced a cyclic usage between
> PVE::RESTEnvironment and PVE::INotify, making code like the following
> fail:
> 
>> perl -e "use PVE::RESTEnvironment qw(log_warn);"
> 
> Note, including the PVE::INotify module first would still work, i.e.:
> 
>> perl -e "use PVE::INotify; use PVE::RESTEnvironment qw(log_warn);"
> 
> The rest of the PVE::INotify module alredy uses syslog(), which could
> be used here as well to get rid of the cyclic usage. Wolfgang argued
> that the whole point of commit e68ebda was to remove coupling between
> the name and the type of the interface. If there still is some code
> about a name starting with 'vmbr' being classified wrong, that should
> rather be fixed. Because of the very commit, the frontend already
> doesn't show e.g. a non-bridge with name 'vmbr7' in bridge selectors.
> 
> Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Fixes: e68ebda ("fix #545: interfaces: allow arbitrary bridge names in network config")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> @Stefan: Do you have any good rationale to rather keep the check?
> 
>  src/PVE/INotify.pm | 4 ----
>  1 file changed, 4 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel