From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist
Date: Thu, 5 Dec 2024 17:20:05 +0100 [thread overview]
Message-ID: <36f10b54-4360-4aad-86de-23a8d37c5815@proxmox.com> (raw)
In-Reply-To: <mailman.835.1732813827.391.pve-devel@lists.proxmox.com>
Seems like this still is a remnant from when we used to configure the
ranges explicitly dhcp-range. But adding two DHCP ranges just generates
two identical lines in the dnsmasq config:
> dhcp-range=set:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,infinite
> dhcp-range=set:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,infinite
Maybe it would make sense to move the whole code of configure_range to
configure_subnet in the Dnsmasq plugin, since the whole subnet gets
configured anyway and make configure_range a noop?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-05 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241128170942.4717-1-lou.lecrivain@wdz.de>
2024-11-28 17:09 ` [pve-devel] SPAM: [PATCH pve-network 1/2] vnet: do not skip if no range is defined, ask for allocation inside prefix instead Lou Lecrivain via pve-devel
2024-12-05 16:08 ` Stefan Hanreich
2024-11-28 17:09 ` [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist Lou Lecrivain via pve-devel
2024-12-05 16:20 ` Stefan Hanreich [this message]
2024-12-06 10:33 ` Lou Lecrivain via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36f10b54-4360-4aad-86de-23a8d37c5815@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.