Re: [pbs-devel] [PATCH proxmox-backup 2/2] datastore: gc: rename method and adapt incorrect comments

[Christian Ebner <c.ebner@proxmox.com>]

On 10/2/25 2:18 PM, Fabian Grünbichler wrote:
> On October 2, 2025 11:11 am, Christian Ebner wrote:
>> ss the helper does not really mark the chunks but rather checks
>> if it should be added to the delete list.
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>>   pbs-datastore/src/datastore.rs | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
>> index 2e62590f9..b76bb1987 100644
>> --- a/pbs-datastore/src/datastore.rs
>> +++ b/pbs-datastore/src/datastore.rs
>> @@ -1654,7 +1654,7 @@ impl DataStore {
>>   
>>                   for content in list_bucket_result.contents {
>>                       if self
>> -                        .mark_chunk_for_object_key(
>> +                        .check_chunk_marker_for_object_key(
>>                               &content.key,
>>                               content.size,
>>                               min_atime,
>> @@ -1796,10 +1796,9 @@ impl DataStore {
>>           Ok(())
>>       }
>>   
>> -    // Mark the chunk marker in the local cache store for the given object key as in use
>> -    // by updating it's atime.
>> -    // Returns Ok(true) if the chunk was updated and Ok(false) if the object was not a chunk.
>> -    fn mark_chunk_for_object_key(
>> +    // Check if the chunk marker in the local cache store for the given object key marks the chunk
>> +    // object as in-use or adds it to the list of objects to delete.
>> +    fn check_chunk_marker_for_object_key(
> 
> this is still wrong - this method doesn't mark anything as in-use, but
> it does remove it from the cache (if eligible), which will also remove
> the cache marker!

Well... it states that it checks whether the marker file marks the chunk 
as in-use (by it's presence). but yeah, I agree that it is not worded to 
be easily comprehended.

Also forgot to adapt the info message just below, so this needs to be 
included as well anyways.

I will improve wording and send this as part of the S3 upload race 
patches I'm working on.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel