Re: [pve-devel] [PATCH common] inotify: avoid cyclic use statement

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 11/11/24 13:10, Fiona Ebner wrote:
>>> The rest of the PVE::INotify module alredy uses syslog(), which could
>>> be used here as well to get rid of the cyclic usage. Wolfgang argued
>>> that the whole point of commit e68ebda was to remove coupling between
>>> the name and the type of the interface. If there still is some code
>>> about a name starting with 'vmbr' being classified wrong, that should
>>> rather be fixed. Because of the very commit, the frontend already
>>> doesn't show e.g. a non-bridge with name 'vmbr7' in bridge selectors.
> 
> If we keep it, syslog() is better than warn here. But why is it better
> for the check to be there than not (like Wolfgang suggested)?

It was intended as a safety net, so we can catch potentially odd setups.
Iirc no one ever reported seeing that warning, so I guess it passed the
scream test.

So, removing this check is fine by me.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel