From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pmg-devel@lists.proxmox.com, Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: Re: [pmg-devel] [PATCH pmg-gui] utils: escape `/` in regex for emails
Date: Mon, 26 Feb 2024 13:14:02 +0100 [thread overview]
Message-ID: <3686e0c2-e23a-4065-a4c8-822f839bd9ee@proxmox.com> (raw)
In-Reply-To: <cc133fce-81fc-4a3b-865c-454f20d7da69@proxmox.com>
Am 26/02/2024 um 08:07 schrieb Dominik Csapak:
> On 2/23/24 19:11, Stoiko Ivanov wrote:
>
FYI: this makes it seem like below was written by Stoiko, but it wasn't,
it's rather part of Maximiliano's original commit message.
>>>
>>> Note that `/` marks the end of the regex [1], hence
>>>
>>> Some@example@oh\no@
>>>
>>> is valid according to this regex if we do not escape `/`.
>>>
>
> is not because of unescaped '/' but because the regex is not anchored
> and thus only parts of the input must match... (and that it does)
>
yeah, that seems indeed to be the issue. @Maximiliano can you please try that
and send a patch for it, if it works out.
And FWIW, the extra parenthesis around the regex could be dropped too (just
a code style improvement though), so
prev parent reply other threads:[~2024-02-26 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 12:44 Maximiliano Sandoval
2024-02-23 18:11 ` Stoiko Ivanov
2024-02-26 7:07 ` Dominik Csapak
2024-02-26 12:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3686e0c2-e23a-4065-a4c8-822f839bd9ee@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.