Re: [pbs-devel] [PATCH proxmox-backup 1/3] tape: media_catalog: add fast_catalog beside normal catalog

[Dominik Csapak <d.csapak@proxmox.com>]

On 7/20/21 08:15, Dietmar Maurer wrote:
> 
>> On 07/19/2021 4:55 PM Dominik Csapak <d.csapak@proxmox.com> wrote:
>>
>>   
>> for some parts of the ui, we only need the snapshot list from the catalog,
>> and reading the whole catalog (can be multiple hundred MiB) is not
>> really necessary.
>>
>> Instead, on every commit of the catalog, write the complete content list
>> into a seperate .index file, that can be read to get only the snapshot
>> list.
> 
> Commits can be quite frequent. Can we write on "close" only?
> 

AFAICS from the code, during a backup to tape, we only commit on tape
end (the "close") or every 128GiB written to tape so not that often
(every ~7 minutes on LTO-8 with 300MB/s)

on tape restore though, we create a 'temporary database' which gets
commited on every archive restore

i'd suggest to either

* add an option to commit for writing the snapshot list, and only set it
   on the last commit

* add some kind of 'finish' or 'close' function to the catalog, that
   must be called

any favorites (or alternatives) ?