all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH guest-common 11/34] guest identity: allow taking over a uid that is unused in the cluster
Date: Tue, 17 Nov 2026 14:14:46 +0100	[thread overview]
Message-ID: <35ea7039-ca22-4266-bc38-302605f6b60d@proxmox.com> (raw)
In-Reply-To: <20261116004703.2908294-12-t.lamprecht@proxmox.com>

aside from the whole pending/reservation handling being hard to follow,

some minor comments inline

On 11/16/26 1:53 AM, Thomas Lamprecht wrote:
[snip]
> +
> +# Publishes $uid, for example the one of a restored backup or of the source guest of a remote
> +# migration, as the uid of the guest $vmid with the current time as rtime, where that is allowed.
> +#
> +# $class is the config class of the guest and must have guest identities enabled. $reservation is
> +# what create_and_lock_config returned for the operation. The caller must still hold the config
> +# lock of $vmid and call this after the final config write of the operation. $uid can be undef if
> +# there is nothing to adopt, for example for a backup without uid.
> +#
> +# A guest that had an identity before the operation keeps it, unless it had $uid as pending uid,
> +# see adoptable_uid. Otherwise, $uid only replaces the identity that the reservation published,
> +# and only if no other guest in the cluster has it. Whatever the outcome, the pending uid of the
> +# config is removed afterwards, as the operation is done.
> +#
> +# Dies if the cluster-wide identity lock cannot be taken, for example without quorum. The pending
> +# uid then stays, as nothing got decided, so that a later operation can still take it over.

i find this whole comment a bit hard to read and to follow:

one paragraph says 'whatever the outcome, the pending uid [..] is 
removed [..]', but the next one says: 'dies if [..]. the pending uid 
then stays'

i get that it's about different error scenarios, but the wording is a
bit confusing here

> +#
> +# Returns a hash with the keys 'result', 'uid' (the uid of $vmid afterwards), 'requested' ($uid)
> +# and, for the result 'in-use', 'in-use-by' (the lowest VMID of the other guests with $uid). The
> +# result is one of:
> +#   kept    - the guest keeps the identity it had before the operation, or already has $uid
> +#   adopted - $uid got published for $vmid
> +#   in-use  - another guest has $uid, the identity of the reservation stays
> +#   changed - the identity of the reservation is not published anymore, nothing got changed
> +#   skipped - $uid is undef, the identity of the reservation stays

same here with the wording:

kept: keeps identity
changed: the identity is not published, nothing got changed

so what is the difference? also 'changed' -> 'nothing got changed' seems 
wrong...

> +sub adopt {
> +    my ($class, $vmid, $uid, $reservation) = @_;
> +
> +    die "guest identities are not enabled for this guest type\n" if !$class->__identity_enabled();
> +    die "missing guest identity reservation\n"
> +        if ref($reservation) ne 'HASH' || !$reservation->{reserved};
> +    die "invalid guest identity uid '$uid'\n" if defined($uid) && !is_valid_uid($uid);
> +
> +    my $res = take_over($class, $vmid, $uid, $reservation);
> +
> +    eval { $class->__identity_clear_pending($vmid) };
> +    die "unable to remove the pending uid - $@" if $@;
> +
> +    return $res;
> +}
> +




  reply	other threads:[~2026-11-17 13:14 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:46 [PATCH cluster/guest-common/qemu-server/container/manager/docs 00/34] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 01/34] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 02/34] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 03/34] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 04/34] pmxcfs: quorum: pass the corosync membership to an optional listener Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 05/34] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 06/34] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 07/34] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-16  0:46 ` [PATCH guest-common 08/34] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-17 10:47   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH guest-common 09/34] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-17 10:47   ` Dominik Csapak
2026-11-17 12:47     ` Dominik Csapak
2026-11-16  0:46 ` [PATCH guest-common 10/34] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-16  0:46 ` [PATCH guest-common 11/34] guest identity: allow taking over a uid that is unused in the cluster Thomas Lamprecht
2026-11-17 13:14   ` Dominik Csapak [this message]
2026-11-16  0:46 ` [PATCH qemu-server 12/34] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 13/34] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 14/34] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 15/34] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-17 15:17   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 16/34] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-17 15:26   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 17/34] api: status: return the guest uid Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 18/34] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 19/34] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 20/34] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 21/34] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 22/34] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 23/34] migrate: remote: clean up the target on a tunnel version mismatch Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 24/34] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 25/34] api: status: return the guest uid Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 26/34] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-17 15:30   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH manager 27/34] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 28/34] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 29/34] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 30/34] ui: guest summary: show " Thomas Lamprecht
2026-11-17 15:44   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH docs 31/34] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 32/34] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 33/34] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 34/34] pct: " Thomas Lamprecht
2026-11-17 10:47 ` [PATCH cluster/guest-common/qemu-server/container/manager/docs 00/34] fix #7846: guest identity (uid) and cluster ID Dominik Csapak
2026-11-17 11:29   ` Thomas Lamprecht
2026-11-17 11:55     ` Dominik Csapak
2026-11-17 12:47       ` Thomas Lamprecht
2026-11-17 13:54         ` Dominik Csapak
2026-11-17 15:55 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35ea7039-ca22-4266-bc38-302605f6b60d@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal