all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH container 20/34] api: migrate, clone: refuse targets that would drop the guest identity
Date: Mon, 16 Nov 2026 01:46:32 +0100	[thread overview]
Message-ID: <20261116004703.2908294-21-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261116004703.2908294-1-t.lamprecht@proxmox.com>

Older pve-container versions drop the 'meta' property when they write a
config, and with it the guest identity. A later write by an upgraded
node then assigns a new identity.

Refuse restart and offline migrations and clones to another node unless
the target reports a version that keeps the identity. Check before the
operation starts, and report such nodes with the versions involved in
the migration preconditions, so that clients can explain the refusal.

The migration API also checks requests that come through HA, but an HA
relocation stops the container before it calls that API. The recovery
of guests from a fenced node moves configs without this check.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 src/PVE/API2/LXC.pm         |  30 ++++++++
 src/test/lifecycle_tests.pl | 147 ++++++++++++++++++++++++++++++++++++
 2 files changed, 177 insertions(+)

diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index b9a1337..3f9281e 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -14,6 +14,7 @@ use PVE::DataCenterConfig;
 use PVE::Exception qw(raise raise_param_exc raise_perm_exc);
 use PVE::Firewall;
 use PVE::GuestHelpers;
+use PVE::GuestIdentity;
 use PVE::INotify;
 use PVE::JSONSchema qw(get_standard_option);
 use PVE::RESTHandler;
@@ -1561,6 +1562,25 @@ __PACKAGE__->register_method({
                             },
                         },
                     },
+                    'guest-identity-unsupported' => {
+                        description =>
+                            "Set if migrating to the node is refused because the node does not"
+                            . " report a Proxmox VE version that keeps the guest identity.",
+                        type => 'object',
+                        optional => 1,
+                        properties => {
+                            version => {
+                                description => "The Proxmox VE version the node reports.",
+                                type => 'string',
+                                optional => 1,
+                            },
+                            'required-version' => {
+                                description =>
+                                    "The minimum Proxmox VE version that keeps the guest identity.",
+                                type => 'string',
+                            },
+                        },
+                    },
                 },
                 description => "List of not allowed nodes with additional information.",
             },
@@ -1623,6 +1643,12 @@ __PACKAGE__->register_method({
                     $blocking_ha_resources;
             }
 
+            # the migration refuses nodes that would drop the guest identity
+            if (my $unsupported = PVE::GuestIdentity::node_identity_unsupported($node)) {
+                $res->{'not-allowed-nodes'}->{$node}->{'guest-identity-unsupported'} =
+                    $unsupported;
+            }
+
             # if nothing came up, add it to the allowed nodes
             if (!defined($res->{'not-allowed-nodes'}->{$node})) {
                 push $res->{'allowed-nodes'}->@*, $node;
@@ -1701,6 +1727,8 @@ __PACKAGE__->register_method({
         PVE::Cluster::check_cfs_quorum();
 
         PVE::Cluster::check_node_exists($target);
+        # an older node drops the guest identity on its next write of the config
+        PVE::GuestIdentity::assert_node_supports_identity($target);
 
         my $targetip = PVE::Cluster::remote_node_ip($target);
 
@@ -2013,6 +2041,8 @@ __PACKAGE__->register_method({
         undef $target if $target && ($target eq $localnode || $target eq 'localhost');
 
         PVE::Cluster::check_node_exists($target) if $target;
+        # an older node drops the guest identity on its next write of the config
+        PVE::GuestIdentity::assert_node_supports_identity($target) if $target;
 
         my $storecfg = PVE::Storage::config();
 
diff --git a/src/test/lifecycle_tests.pl b/src/test/lifecycle_tests.pl
index 2e31984..47391c9 100755
--- a/src/test/lifecycle_tests.pl
+++ b/src/test/lifecycle_tests.pl
@@ -24,6 +24,7 @@ use Test::More;
 
 use PVE::Cluster;
 use PVE::GuestHelpers;
+use PVE::GuestIdentity;
 use PVE::INotify;
 use PVE::JSONSchema;
 use PVE::Tools qw(file_get_contents file_set_contents);
@@ -81,9 +82,21 @@ my $storage_cfg = {
             path => '/var/lib/vz',
             content => { rootdir => 1, images => 1, backup => 1, vztmpl => 1 },
         },
+        shared => {
+            type => 'nfs',
+            path => '/mnt/pve/shared',
+            shared => 1,
+            content => { rootdir => 1, images => 1 },
+        },
     },
 };
 
+# reported Proxmox VE versions of the other cluster nodes
+my $node_versions = {
+    'new-node' => '9.2.29',
+    'old-node' => '9.2.28',
+};
+
 my $cluster_module = Test::MockModule->new('PVE::Cluster');
 $cluster_module->mock(
     cfs_update => sub { },
@@ -115,6 +128,19 @@ $cluster_module->mock(
         return undef if $noerr;
         die "CT $vmid already exists on node '$NODENAME'\n";
     },
+    remote_node_ip => sub { return '192.0.2.1' },
+    get_node_pvecfg_version => sub {
+        my ($node) = @_;
+        return $node_versions->{$node};
+    },
+    node_pvecfg_version_at_least => sub {
+        my ($node, @required) = @_;
+        my @version = split(/\./, $node_versions->{$node} // return 0);
+        for my $i (0 .. 2) {
+            return $version[$i] > $required[$i] if $version[$i] != $required[$i];
+        }
+        return 1;
+    },
 );
 
 my $api_module = Test::MockModule->new('PVE::API2::LXC');
@@ -801,6 +827,127 @@ subtest 'post-stop hook keeps an identity published while it ran' => sub {
     $lxc_module->unmock('get_staging_tempfs', 'vm_stop_cleanup');
 };
 
+subtest 'migration is refused to nodes that drop the guest identity' => sub {
+    reset_configs();
+    my $raw = existing_config('ctime=1500000000,rtime=1500000000000,uid=existingexistingexis');
+    write_raw_config(200, $raw);
+
+    my $migrated_to;
+    my $migrate_module = Test::MockModule->new('PVE::LXC::Migrate');
+    $migrate_module->mock(migrate => sub { $migrated_to = $_[1] });
+    my $ha_config_module = Test::MockModule->new('PVE::HA::Config');
+    $ha_config_module->mock(vm_is_ha_managed => sub { return 0 });
+
+    my $migrate = sub {
+        my ($target, $param) = @_;
+        return run_task(sub {
+            PVE::API2::LXC->migrate_vm({
+                node => $NODENAME,
+                vmid => 200,
+                target => $target,
+                ($param // {})->%*,
+            });
+        });
+    };
+
+    my $err = $migrate->('old-node');
+    like($err, qr/node 'old-node' runs Proxmox VE 9\.2\.28/, 'node too old is refused');
+    $err = $migrate->('unknown-node');
+    like($err, qr/does not report its Proxmox VE version/, 'node without version is refused');
+
+    my $stopped = 0;
+    $lxc_module->mock(
+        check_running => sub { return 1 },
+        vm_stop => sub { $stopped = 1 },
+    );
+    $err = $migrate->('old-node', { restart => 1 });
+    $lxc_module->mock(check_running => sub { return 0 });
+    $lxc_module->unmock('vm_stop');
+    like($err, qr/node 'old-node' runs Proxmox VE 9\.2\.28/, 'restart migration is refused');
+    ok(!$stopped, 'running container is not stopped');
+
+    ok(!defined($migrated_to), 'migration does not start');
+    is(read_raw_config(200), $raw, 'config is unchanged');
+
+    $err = $migrate->('new-node');
+    is($err, '', 'migration to an upgraded node starts');
+    is($migrated_to, 'new-node', 'migration goes to the target');
+};
+
+subtest 'migration preconditions list nodes that drop the guest identity' => sub {
+    reset_configs();
+    my $raw = existing_config('ctime=1500000000,rtime=1500000000000,uid=existingexistingexis');
+    write_raw_config(200, $raw);
+
+    my $ha_config_module = Test::MockModule->new('PVE::HA::Config');
+    $ha_config_module->mock(vm_is_ha_managed => sub { return 0 });
+    $cluster_module->mock(
+        get_nodelist => sub { return [$NODENAME, 'new-node', 'old-node', 'unknown-node'] },
+    );
+
+    my $res = PVE::API2::LXC->migrate_vm_precondition({ node => $NODENAME, vmid => 200 });
+    $cluster_module->unmock('get_nodelist');
+
+    my $required = PVE::GuestIdentity::MIN_PVE_MANAGER_VERSION;
+    is_deeply($res->{'allowed-nodes'}, ['new-node'], 'only the upgraded node is allowed');
+    is_deeply(
+        $res->{'not-allowed-nodes'},
+        {
+            'old-node' => {
+                'guest-identity-unsupported' => {
+                    version => '9.2.28',
+                    'required-version' => $required,
+                },
+            },
+            'unknown-node' => {
+                'guest-identity-unsupported' => { 'required-version' => $required },
+            },
+        },
+        'nodes that drop the identity are not allowed',
+    );
+
+    my $returns = PVE::API2::LXC->map_method_by_name('migrate_vm_precondition')->{returns};
+    eval { PVE::JSONSchema::validate($res, $returns) };
+    is($@, '', 'result matches the schema');
+    # the schema documents the reasons of a node as the properties of 'not-allowed-nodes'
+    my $reasons_schema =
+        { $returns->{properties}->{'not-allowed-nodes'}->%*, additionalProperties => 0 };
+    for my $node ('old-node', 'unknown-node') {
+        my $reasons = $res->{'not-allowed-nodes'}->{$node};
+        eval { PVE::JSONSchema::validate($reasons, $reasons_schema) };
+        is($@, '', "reason for $node is documented in the schema");
+    }
+};
+
+subtest 'clone to another node is refused if the node drops the guest identity' => sub {
+    reset_configs();
+    my $raw = <<~'EOF';
+        arch: amd64
+        hostname: existing
+        memory: 512
+        meta: ctime=1500000000,rtime=1500000000000,uid=existingexistingexis
+        ostype: debian
+        rootfs: shared:200/vm-200-disk-0.raw,size=4G
+        unprivileged: 1
+        EOF
+    write_raw_config(200, $raw);
+    make_path(cfs_file("nodes/new-node/lxc"));
+
+    my $err = clone_ct(200, 201, { target => 'old-node' });
+    like($err, qr/node 'old-node' runs Proxmox VE 9\.2\.28/, 'clone is refused');
+    is(read_raw_config(200), $raw, 'source is unchanged');
+    ok(!defined(read_raw_config(201)), 'no clone is created');
+
+    $err = clone_ct(200, 201, { target => 'new-node' });
+    is($err, '', 'clone to an upgraded node succeeds') or diag($task_log);
+    my $clone_raw = read_raw_config(201, 'new-node');
+    ok(defined($clone_raw), 'clone is moved to the target node');
+    my $identity =
+        PVE::GuestIdentity::parse_identity($clone_raw =~ m/^meta: (.*)$/m ? $1 : undef);
+    like($identity->{uid}, qr/^[a-z2-7]{20}$/, 'clone has a uid');
+    isnt($identity->{uid}, 'existingexistingexis', 'clone has a new uid');
+};
+
 remove_tree($WORKDIR);
 
 done_testing();
-- 
2.47.3





  parent reply	other threads:[~2026-11-16  0:49 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:46 [PATCH cluster/guest-common/qemu-server/container/manager/docs 00/34] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 01/34] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 02/34] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 03/34] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 04/34] pmxcfs: quorum: pass the corosync membership to an optional listener Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 05/34] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 06/34] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 07/34] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-16  0:46 ` [PATCH guest-common 08/34] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-17 10:47   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH guest-common 09/34] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-17 10:47   ` Dominik Csapak
2026-11-17 12:47     ` Dominik Csapak
2026-11-16  0:46 ` [PATCH guest-common 10/34] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-16  0:46 ` [PATCH guest-common 11/34] guest identity: allow taking over a uid that is unused in the cluster Thomas Lamprecht
2026-11-17 13:14   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 12/34] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 13/34] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 14/34] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 15/34] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-17 15:17   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 16/34] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-17 15:26   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 17/34] api: status: return the guest uid Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 18/34] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 19/34] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-16  0:46 ` Thomas Lamprecht [this message]
2026-11-16  0:46 ` [PATCH container 21/34] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 22/34] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 23/34] migrate: remote: clean up the target on a tunnel version mismatch Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 24/34] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 25/34] api: status: return the guest uid Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 26/34] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-17 15:30   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH manager 27/34] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 28/34] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 29/34] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 30/34] ui: guest summary: show " Thomas Lamprecht
2026-11-17 15:44   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH docs 31/34] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 32/34] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 33/34] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 34/34] pct: " Thomas Lamprecht
2026-11-17 10:47 ` [PATCH cluster/guest-common/qemu-server/container/manager/docs 00/34] fix #7846: guest identity (uid) and cluster ID Dominik Csapak
2026-11-17 11:29   ` Thomas Lamprecht
2026-11-17 11:55     ` Dominik Csapak
2026-11-17 12:47       ` Thomas Lamprecht
2026-11-17 13:54         ` Dominik Csapak
2026-11-17 15:55 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116004703.2908294-21-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal