all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH xtermjs] fix #2980: do not prompt for leaving on reconnect/disconnect
@ 2020-11-23 15:41 Dominik Csapak
  2020-11-24 13:42 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-11-23 15:41 UTC (permalink / raw)
  To: pve-devel

this includes migration detection

basically we should only enable this when we are fully connected

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/www/main.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/www/main.js b/src/www/main.js
index a3713f4..c2811f6 100644
--- a/src/www/main.js
+++ b/src/www/main.js
@@ -39,11 +39,13 @@ function updateState(newState, msg, code) {
 	    message = "Connected";
 	    break;
 	case states.disconnecting:
+	    window.onbeforeunload = undefined;
 	    message = "Disconnecting...";
 	    timeout = 0;
 	    severity = severities.warning;
 	    break;
 	case states.reconnecting:
+	    window.onbeforeunload = undefined;
 	    message = "Reconnecting...";
 	    timeout = 0;
 	    severity = severities.warning;
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH xtermjs] fix #2980: do not prompt for leaving on reconnect/disconnect
  2020-11-23 15:41 [pve-devel] [PATCH xtermjs] fix #2980: do not prompt for leaving on reconnect/disconnect Dominik Csapak
@ 2020-11-24 13:42 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-11-24 13:42 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 23.11.20 16:41, Dominik Csapak wrote:
> this includes migration detection
> 
> basically we should only enable this when we are fully connected
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/www/main.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-24 13:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 15:41 [pve-devel] [PATCH xtermjs] fix #2980: do not prompt for leaving on reconnect/disconnect Dominik Csapak
2020-11-24 13:42 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal