all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 qemu-server] fix #4201: delete cloud-init disk on rollback
Date: Fri, 11 Nov 2022 19:27:25 +0100	[thread overview]
Message-ID: <356d914a-1ec4-a0d2-4c0d-bc0fcbe936d4@proxmox.com> (raw)
In-Reply-To: <20221111154635.394997-1-m.limbeck@proxmox.com>

Am 11/11/2022 um 16:46 schrieb Mira Limbeck:
> If the config doesn't contain the cloud-init disk anymore after the
> rollback, we have to clean it up since otherwise no further disk can be
> attached unless the one still existing on the storage is deleted.
> 
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>
> Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> v3:
>  - rebased on top of master
>  - added R-b/T-b tags from v2
> v2:
>  - chose the add_unused_volume way as @fiona recommended, the
>    implementation is a lot cleaner, but contains a cloudinit regex
> 
>  - removed the 2nd patch for reusing already existing disks when
>    adding a cloudinit disk
> 
>  PVE/QemuConfig.pm | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
>

applied, thanks to both of you!




      reply	other threads:[~2022-11-11 18:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 15:46 [pve-devel] " Mira Limbeck
2022-11-11 18:27 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=356d914a-1ec4-a0d2-4c0d-bc0fcbe936d4@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal