From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node
Date: Fri, 6 May 2022 10:00:50 +0200 [thread overview]
Message-ID: <34ee9614-74dd-8556-3c53-84efdbeab553@proxmox.com> (raw)
In-Reply-To: <20220505142709.1128710-1-m.heiserer@proxmox.com>
Am 5/5/22 um 16:27 schrieb Matthias Heiserer:
> One step of installing ceph is creating a monitor. When installing via
> the datacenter and from a node other than the first node, clicking "next"
> without changing the monitor node could result in the error
> 'binary not installed: /usr/bin/ceph-mon', as it would try to install
> the monitor on the first node, although ceph was installed on the current
> node.
>
> With this patch, the current node is preselected.
> This has no effect when installing ceph on a specific node, as the node
> selector overwrites the preferred value in that case.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> www/manager6/ceph/CephInstallWizard.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
> index 59458b0d..ebdc7f1d 100644
> --- a/www/manager6/ceph/CephInstallWizard.js
> +++ b/www/manager6/ceph/CephInstallWizard.js
> @@ -403,6 +403,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
> name: 'mon-node',
> selectCurNode: true,
> allowBlank: false,
> + preferredValue: Proxmox.NodeName,
That is always the local node one is connected through the web interface.
So, what if I'm connected through Node A but currently installing/initializing ceph on Node B?
Should this rather be the node currently selected in the resource tree?
> },
> {
> xtype: 'displayfield',
next prev parent reply other threads:[~2022-05-06 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 14:27 Matthias Heiserer
2022-05-06 8:00 ` Thomas Lamprecht [this message]
2022-05-06 8:11 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34ee9614-74dd-8556-3c53-84efdbeab553@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.