From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [pbs-devel] [PATCH proxmox-backup v4 1/1] file-restore: make dynamic memory behaviour controllable
Date: Tue, 15 Nov 2022 09:29:02 +0100 [thread overview]
Message-ID: <34c375db-45e4-05e8-6bfa-373c951149bb@proxmox.com> (raw)
In-Reply-To: <20221110103634.2177856-2-d.csapak@proxmox.com>
Am 10/11/2022 um 11:36 schrieb Dominik Csapak:
> by adding 'dynamic-memory' parameter that controls if we automatically
> increase the memory of the guest vm or not
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> new in v4
>
> not really happy with the 'clippy allow', but imho there is no obvious way to
> bundle those parameters without restructuring the code much
>
> proxmox-file-restore/src/block_driver.rs | 10 +++-
> proxmox-file-restore/src/block_driver_qemu.rs | 6 ++-
> proxmox-file-restore/src/main.rs | 54 +++++++++++++++++--
> 3 files changed, 61 insertions(+), 9 deletions(-)
>
>
applied, but superseeded looping thorugh a new param over quite a few function by
getting this out from the PBS_FILE_RESTORE_MEM_HOTPLUG_ALLOW environment variable
being set to "true", thanks!
Note that I also made a few other followups to that code, e.g., introducing QMPSock
to avoid having QMP internals in a rather unrelated function, among other things.
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup v4 1/1] file-restore: make dynamic memory behaviour controllable
Date: Tue, 15 Nov 2022 09:29:02 +0100 [thread overview]
Message-ID: <34c375db-45e4-05e8-6bfa-373c951149bb@proxmox.com> (raw)
In-Reply-To: <20221110103634.2177856-2-d.csapak@proxmox.com>
Am 10/11/2022 um 11:36 schrieb Dominik Csapak:
> by adding 'dynamic-memory' parameter that controls if we automatically
> increase the memory of the guest vm or not
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> new in v4
>
> not really happy with the 'clippy allow', but imho there is no obvious way to
> bundle those parameters without restructuring the code much
>
> proxmox-file-restore/src/block_driver.rs | 10 +++-
> proxmox-file-restore/src/block_driver_qemu.rs | 6 ++-
> proxmox-file-restore/src/main.rs | 54 +++++++++++++++++--
> 3 files changed, 61 insertions(+), 9 deletions(-)
>
>
applied, but superseeded looping thorugh a new param over quite a few function by
getting this out from the PBS_FILE_RESTORE_MEM_HOTPLUG_ALLOW environment variable
being set to "true", thanks!
Note that I also made a few other followups to that code, e.g., introducing QMPSock
to avoid having QMP internals in a rather unrelated function, among other things.
next prev parent reply other threads:[~2022-11-15 8:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 10:36 [pve-devel] [PATCH proxmox-backup/common/storage v4] improve file-restore timeout behaviour Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-10 10:36 ` [pve-devel] [PATCH proxmox-backup v4 1/1] file-restore: make dynamic memory behaviour controllable Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 8:29 ` Thomas Lamprecht [this message]
2022-11-15 8:29 ` [pbs-devel] applied: " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH common v4 1/2] PBSClient: file_restore_list: add extraParams and use timeout Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 12:27 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-15 12:27 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH common v4 2/2] PBSClient: add optional 'dynamic-memory' parameter to file-restore commands Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-10 10:36 ` [pve-devel] [PATCH storage v4 1/3] api: FileRestore: decode and return proper error of file-restore listing Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 12:27 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-15 12:27 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH storage v4 2/3] api: FileRestore: make use of file-restores and guis timeout mechanism Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
2022-11-15 12:28 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-15 12:28 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2022-11-10 10:36 ` [pve-devel] [PATCH storage v4 3/3] api: FileRestore: allow automatic memory increase for privileged users Dominik Csapak
2022-11-10 10:36 ` [pbs-devel] " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c375db-45e4-05e8-6bfa-373c951149bb@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal