[pbs-devel] applied: [PATCH proxmox] notify: remove irritating 'html template not found' log message

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 26.11.24 um 10:30 schrieb Lukas Wagner:
> The proxmox-notify crate can render notification text based on two
> different templates, plaintext and html. The html template is at the
> moment only used for email-based notifications. If we try to render
> a html-formatted message but there is no html template, we try to
> fall back to the plaintext template and wrap the rendered message
> in <pre> tags.
> As a preparation for user-supplied/overridden templates, I added a log
> message "html template not found, falling back to plaintext ..." to
> educate the user about this behavior.
> 
> In Proxmox Backup Server, we only ship plaintext templates at the
> moment, meaning that this log message will be shown for every single
> (email) notification that is sent out. This might be a bit confusing,
> because the log message can be interpreted as an error, which it isn't.
> 
> This commit removes the log message completely for now. Once we add
> support for user-overridable notification templates we could consider
> adding it back it, but maybe phrased a bit differently, to avoid it
> being interpreted as an error.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  proxmox-notify/src/renderer/mod.rs | 1 -
>  1 file changed, 1 deletion(-)
> 
>

applied, thanks!

Anything pending for the notify crate? As else I'd do a bump now already.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel