From: Fiona Ebner <f.ebner@proxmox.com>
To: pmg-devel@lists.proxmox.com,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes
Date: Tue, 4 Oct 2022 10:08:14 +0200 [thread overview]
Message-ID: <33f63b51-6d44-df5f-64bc-0d69cd78c077@proxmox.com> (raw)
In-Reply-To: <20220720105948.291740-1-f.ebner@proxmox.com>
Am 20.07.22 um 12:59 schrieb Fabian Ebner:
> Mostly done in preparation for #3186 (refactor pbs client use in PVE),
> to avoid the need to manually set the namespace for all call-sites in
> PVE, when it's already present in the storage/PBS config.
>
> pve-common 1/5 and 2/5 and pmg-api 1/1 are improvements touching parts
> of the same infrastructure, but not directly related.
>
> The other patches change PBSClient to auto-select the namespace from
> its initial configuration if not explicitly overriden with a
> namespaced parameter and deprecate namespaced parameters as a whole.
>
> Rationale is that essentially all current users of PBSClient are
> configured for one namespace (there is the "status" call, which
> doesn't depend on a namespace, but that doesn't contradict the
> previous claim). It's less work on the call sites and there's no risk
> to forget namespacing a parameter (as happened with pxar_restore in
> PMG) if the PBSClient handles it itself.
>
> If the need for handling more than one namespace with a single client
> ever arises, we can still add e.g. a set_namespace() function to the
> PBSClient.
>
> Also makes it possible to restore a backup from a namespace in PMG,
> which currently fails.
>
>
> Dependency bump for new pve-common is needed for pve-storage and
> pmg-api.
>
>
Ping
WARNING: multiple messages have this Message-ID
From: Fiona Ebner <f.ebner@proxmox.com>
To: pmg-devel@lists.proxmox.com,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes
Date: Tue, 4 Oct 2022 10:08:14 +0200 [thread overview]
Message-ID: <33f63b51-6d44-df5f-64bc-0d69cd78c077@proxmox.com> (raw)
In-Reply-To: <20220720105948.291740-1-f.ebner@proxmox.com>
Am 20.07.22 um 12:59 schrieb Fabian Ebner:
> Mostly done in preparation for #3186 (refactor pbs client use in PVE),
> to avoid the need to manually set the namespace for all call-sites in
> PVE, when it's already present in the storage/PBS config.
>
> pve-common 1/5 and 2/5 and pmg-api 1/1 are improvements touching parts
> of the same infrastructure, but not directly related.
>
> The other patches change PBSClient to auto-select the namespace from
> its initial configuration if not explicitly overriden with a
> namespaced parameter and deprecate namespaced parameters as a whole.
>
> Rationale is that essentially all current users of PBSClient are
> configured for one namespace (there is the "status" call, which
> doesn't depend on a namespace, but that doesn't contradict the
> previous claim). It's less work on the call sites and there's no risk
> to forget namespacing a parameter (as happened with pxar_restore in
> PMG) if the PBSClient handles it itself.
>
> If the need for handling more than one namespace with a single client
> ever arises, we can still add e.g. a set_namespace() function to the
> PBSClient.
>
> Also makes it possible to restore a backup from a namespace in PMG,
> which currently fails.
>
>
> Dependency bump for new pve-common is needed for pve-storage and
> pmg-api.
>
>
Ping
next prev parent reply other threads:[~2022-10-04 8:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 10:59 [pve-devel] " Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 1/5] pbs client: delete password: return success for non-existent file Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 2/5] pbs client: forget snapshot: suppress output Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 3/5] pbs client: default to configured namespace for non-namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-11-04 8:44 ` [pve-devel] " Fiona Ebner
2022-11-04 8:44 ` Fiona Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-common 4/5] pbs client: deprecate namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-22 10:53 ` [pve-devel] " Wolfgang Bumiller
2022-07-22 10:53 ` [pmg-devel] " Wolfgang Bumiller
2022-07-25 8:04 ` Fiona Ebner
2022-07-25 8:04 ` [pmg-devel] " Fiona Ebner
2022-11-04 13:16 ` [pve-devel] applied-series: " Wolfgang Bumiller
2022-11-04 13:16 ` [pmg-devel] " Wolfgang Bumiller
2022-07-20 10:59 ` [pve-devel] [PATCH pmg-api 1/2] api: get group snapshots: take backup-id into account Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-11-04 13:28 ` [pve-devel] applied-series: " Wolfgang Bumiller
2022-11-04 13:28 ` [pmg-devel] " Wolfgang Bumiller
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pmg-api 2/2] api: pbs: don't use namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-storage 1/1] api: pbs: file restore: " Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] " Fabian Ebner
2022-11-04 13:17 ` [pve-devel] applied: " Wolfgang Bumiller
2022-11-04 13:17 ` [pmg-devel] " Wolfgang Bumiller
2022-10-04 8:08 ` Fiona Ebner [this message]
2022-10-04 8:08 ` [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f63b51-6d44-df5f-64bc-0d69cd78c077@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal