Re: [PATCH pve-manager 1/8] ui: VMCPUFlagSelector: Fix unknownFlags behaviour

[Fiona Ebner <f.ebner@proxmox.com>]

Am 12.03.26 um 9:39 AM schrieb Arthur Bied-Charreton:
> ...and typo in name.
> 
> Original patch:
> https://lore.proxmox.com/pve-devel/20211028114150.3245864-6-s.reiter@proxmox.com/
> 

Pre-existing, but the commit message/title should describe what exactly
is fixed. Also, might be nicer to have the renaming be a separate commit.

> Originally-by: Stefan Reiter <s.reiter@proxmox.com>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  www/manager6/form/VMCPUFlagSelector.js | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index 922fcfa6..74b1a2c4 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -14,7 +14,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>      scrollable: 'y',
>      height: 200,
>  
> -    unkownFlags: [],
> +    unknownFlags: [],
>  
>      store: {
>          type: 'store',
> @@ -62,32 +62,32 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>              }
>          });
>  
> -        flags += me.unkownFlags.join(';');
> +        flags += (me.unknownFlags.length > 0 ? ';' : '') + me.unknownFlags.join(';');
>  
>          return flags;
>      },
>  
> -    // Adjusts the store for the current value and determines the unkown flags based on what the
> +    // Adjusts the store for the current value and determines the unknown flags based on what the
>      // store does not know.
>      adjustStoreForValue: function () {
>          let me = this;
>          let store = me.getStore();
>          let value = me.value;
>  
> -        me.unkownFlags = [];
> +        me.unknownFlags = [];
>  
>          store.getData().each((rec) => rec.set('state', '='));
>  
>          let flags = value ? value.split(';') : [];
>          flags.forEach(function (flag) {
>              let sign = flag.substr(0, 1);
> -            flag = flag.substr(1);
> +            let flagName = flag.substr(1);
>  
> -            let rec = store.findRecord('name', flag, 0, false, true, true);
> +            let rec = store.findRecord('name', flagName, 0, false, true, true);
>              if (rec !== null) {
>                  rec.set('state', sign);
>              } else {
> -                me.unkownFlags.push(flag);
> +                me.unknownFlags.push(flag);
>              }
>          });
>