all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] tui: switch to `f64` for disk sizes
Date: Thu, 22 Jun 2023 14:36:08 +0200	[thread overview]
Message-ID: <3369a7c4-ee15-5de0-7f80-d74eaa30f902@proxmox.com> (raw)
In-Reply-To: <20230622092038.205553-1-s.sterz@proxmox.com>

Am 22/06/2023 um 11:20 schrieb Stefan Sterz:
> previously the tui used `u64` internally to represent the disk size.
> since the perl-based installer expects GiB as floats and that is also
> what is displayed in the tui that meant a lot of converting back and
> forth. it also lead to an error where the disk sizes that were set
> seemed to not have been persisted, even though the sizes were
> correctly set. this commit refactors the installer to convert the size
> once in the beginning and then stick to `f64`.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  proxmox-tui-installer/src/options.rs   | 26 ++++++++++++--------------
>  proxmox-tui-installer/src/setup.rs     | 16 ++++++++--------
>  proxmox-tui-installer/src/views/mod.rs | 18 +++++++-----------
>  3 files changed, 27 insertions(+), 33 deletions(-)
> 
>

applied, with Christophs T-b and R-b, thanks!




      parent reply	other threads:[~2023-06-22 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22  9:20 [pve-devel] " Stefan Sterz
2023-06-22 10:28 ` Christoph Heiss
2023-06-22 12:36 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3369a7c4-ee15-5de0-7f80-d74eaa30f902@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal