Re: [pmg-devel] [PATCH pmg-api 1/1] [pmg-api]: fix #3098 : first check for exact domain match

[Daniel Berteaud <daniel@firewall-services.com>]

----- Le 27 Oct 20, à 12:39, Stoiko Ivanov s.ivanov@proxmox.com a écrit :

> Hi,
> 
> Thank you very much for catching this, opening a report and directly
> providing a patch!
> 
> The patch works as advertised (gave it a quick spin on my test-setup).
> 
> However I wonder if it wouldn't be better to address this by sorting
> properly - instead of differentiating between exact match and first
> matching subdomain we could match for the longest matching subdomain
> (suggestion inline).
> This should cover your issue as well as far as I can tell, and provide
> fewer suprises regarding the chosen signing domain.
> 
> What do you think?

I'll give your proposal a try and report back (my perl sort-fu is a bit rusty :-) )

Cheers,
Daniel


-- 
[ https://www.firewall-services.com/ ] 	
Daniel Berteaud 
FIREWALL-SERVICES SAS, La sécurité des réseaux 
Société de Services en Logiciels Libres 
Tél : +33.5 56 64 15 32 
Matrix: @dani:fws.fr 
[ https://www.firewall-services.com/ | https://www.firewall-services.com ]