From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer v2 0/3] tui: remove global, unsafe setup info
Date: Wed, 25 Oct 2023 19:04:23 +0200 [thread overview]
Message-ID: <334abe4b-f548-4e10-bf89-6eb89d3e6c9f@proxmox.com> (raw)
In-Reply-To: <20231025085634.171618-1-c.heiss@proxmox.com>
Am 25/10/2023 um 10:56 schrieb Christoph Heiss:
> Removes the `static mut` for holding a `SetupInfo` instance.
>
> This is done by either passing the needed info as parameter, or in some
> cases, the needed information is already available through other means.
>
> Not only does it get rid of some ugly, unsafe code, it is needed anyway
> as a prerequisite by Aaron for pulling out non-TUI-related code into a
> separate, shared crate.
>
> No functional changes overall.
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059335.html
>
> Changes v1 -> v2:
> * Rebased on latest master, no actual changes otherwise
>
> Christoph Heiss (3):
> tui: refactor `NetworkOptions` to have a `defaults_from()` function
> tui: bootdisk: pass down product info to advanced dialog
> tui: remove obsolete, global `SetupInfo` state
applied series, thanks!
prev parent reply other threads:[~2023-10-25 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:56 [pve-devel] " Christoph Heiss
2023-10-25 8:56 ` [pve-devel] [PATCH installer v2 1/3] tui: refactor `NetworkOptions` to have a `defaults_from()` function Christoph Heiss
2023-10-25 8:56 ` [pve-devel] [PATCH installer v2 2/3] tui: bootdisk: pass down product info to advanced dialog Christoph Heiss
2023-10-25 8:56 ` [pve-devel] [PATCH installer v2 3/3] tui: remove obsolete, global `SetupInfo` state Christoph Heiss
2023-10-25 17:04 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=334abe4b-f548-4e10-bf89-6eb89d3e6c9f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal