[pve-devel] [PATCH manager] ui: guest importer: use 4m efitype for imported vms

[pve-devel] [PATCH manager] ui: guest importer: use 4m efitype for imported vms

[Dominik Csapak]

If we omit the 'efitype' property, the legacy 2m images get used, so
explicitly use the 4m variant.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/window/GuestImport.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 1858bf18..3e7fff39 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -408,6 +408,7 @@ Ext.define('PVE.window.GuestImport', {
                             }
                             data.file += ':0'; // for our special api format
                             if (id === 'efidisk0') {
+                                data.efitype = '4m';
                                 delete data['import-from'];
                             }
                             config[id] = PVE.Parser.printQemuDrive(data);
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] ui: guest importer: use 4m efitype for imported vms

[Thomas Lamprecht]

On Tue, 15 Jul 2025 14:08:51 +0200, Dominik Csapak wrote:
> If we omit the 'efitype' property, the legacy 2m images get used, so
> explicitly use the 4m variant.
> 
> 

Applied, to master and stable-8, thanks!

We probably should change the deafult here for newly created VMs in the backend
(besides the backup restore path), to ensure we can actually start to sunset
the legacy images in a future major release.

[1/1] ui: guest importer: use 4m efitype for imported vms
      commit: 3397634b5985bda2d2c42006ab325adffc12b566


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] applied: [PATCH manager] ui: guest importer: use 4m efitype for imported vms

[Dominik Csapak]

On 7/15/25 14:51, Thomas Lamprecht wrote:
> On Tue, 15 Jul 2025 14:08:51 +0200, Dominik Csapak wrote:
>> If we omit the 'efitype' property, the legacy 2m images get used, so
>> explicitly use the 4m variant.
>>
>>
> 
> Applied, to master and stable-8, thanks!
> 
> We probably should change the deafult here for newly created VMs in the backend
> (besides the backup restore path), to ensure we can actually start to sunset
> the legacy images in a future major release.

yes that makes sense, I can look at it next week

> 
> [1/1] ui: guest importer: use 4m efitype for imported vms
>        commit: 3397634b5985bda2d2c42006ab325adffc12b566



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel