From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2 1/2] ui: form: add TwoColumnContainer
Date: Mon, 22 Apr 2024 11:30:11 +0200 [thread overview]
Message-ID: <331b9f41-a8de-4afb-b3e2-dd7620691b76@proxmox.com> (raw)
In-Reply-To: <20240422081646.838784-1-d.csapak@proxmox.com>
Am 22/04/2024 um 10:16 schrieb Dominik Csapak:
> this is a container, showing a widget on the left column and another one
> on the right one, with a (default) flex ratio of 1:2
>
> this is helpful when wanting fields to align vertically in an input
> panel that have different height (e.g. because of text wrapping)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * make the container more generic as a simple container that holds two
> widgets, so it can be useful in more situations
>
> www/manager6/Makefile | 1 +
> www/manager6/form/TwoColumnContainer.js | 53 +++++++++++++++++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 www/manager6/form/TwoColumnContainer.js
>
>
applied both patches with some rework, thanks!
Reworked was:
- startWidget -> startColumn and same for the end one
- expose both start and end flex, and name it flex again as it's then not
guaranteed to be a 1/x ratio anymore, and flex is more widely used.
- exposed the columnPadding, can be nice to make it narrower for some UIs
- fixed the eslint warnings of the second patch and integrated changes from
the first one also in there.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-22 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 8:16 [pve-devel] " Dominik Csapak
2024-04-22 8:16 ` [pve-devel] [PATCH manager v2 2/2] ui: use pveTwoColumnContainer for the advanced backup options Dominik Csapak
2024-04-22 8:22 ` Fiona Ebner
2024-04-22 8:28 ` Fiona Ebner
2024-04-22 9:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331b9f41-a8de-4afb-b3e2-dd7620691b76@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.