From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH eslint] change from CLIEngine to ESLint
Date: Mon, 6 Dec 2021 14:40:41 +0100 [thread overview]
Message-ID: <331442cf-5df6-9853-d552-e67700f3c366@proxmox.com> (raw)
In-Reply-To: <20211202125418.41303-1-d.csapak@proxmox.com>
On 02.12.21 13:54, Dominik Csapak wrote:
> 8.0 officialy removed CLIEngine (though it's still in git) so use
> the current and supported API.
>
> Necessary changes:
> * use 'ESLint' instead of 'CLIEngine'
> * use 'lintFiles' instead of 'executeOnFiles' (thats async now)
> * adapt to the change of return value of 'lintFiles'
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> after appliying this, we have to 'make buildupstream' again, since the
> included code changes (CLIEngine -> ESLint)
>
> patches/0001-adapt-webpack-config.patch | 2 +-
> src/bin/app.js | 4 ++--
> src/lib/worker.js | 12 +++++++-----
> 3 files changed, 10 insertions(+), 8 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-12-06 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 12:54 [pve-devel] " Dominik Csapak
2021-12-06 13:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331442cf-5df6-9853-d552-e67700f3c366@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.