From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH common 1/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB
Date: Sun, 1 Jun 2025 11:48:36 +0200 [thread overview]
Message-ID: <3307fd93-89bc-4a66-9ad2-08dac89b119b@proxmox.com> (raw)
In-Reply-To: <20250512124129.91914-2-f.ebner@proxmox.com>
Am 12.05.25 um 14:41 schrieb Fiona Ebner:
> The single-letter suffixes are ambiguous and especially in the context
> of disks, the powers of ten are usually used. Proxmox VE uses
> multiples of 1024 however. By adapting format_size() to use the verbose
> suffixes all newly written or re-written sizes will use the more
> verbose/explicit suffix.
>
> The single-letter suffixes stay supported for backwards-compatibility
> for API/CLI users as well as parsing backup configurations. The
> function is currently also used for parsing the 'target-size' Ceph
> pool option (still restricted via schema to single-letter suffixes).
>
> NOTE: maybe it makes sense to wait for PVE 9 with this and do a
> parse+write for all guest configs (including their snapshots) in
> the pve8to9 script?
I would split parsing and serialization so that we can apply the change
to parse_size for PVE 8 also, making the transition smoother and not
requiring any read-write all config steps, which would be a huge PITA
for users.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-01 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 12:41 [pve-devel] [RFC common/manager/qemu-server 0/5] " Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH common 1/5] " Fiona Ebner
2025-06-01 9:48 ` Thomas Lamprecht [this message]
2025-05-12 12:41 ` [pve-devel] [PATCH manager 2/5] vzdump: use verbose size suffix when logging archive file size Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH manager 3/5] test: adapt tests to use verbose disk size suffixes Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 4/5] test: fix tests for changes when printing disk size suffix Fiona Ebner
2025-05-12 12:41 ` [pve-devel] [PATCH qemu-server 5/5] test: adapt all tests to use verbose disk size suffixes Fiona Ebner
2025-05-12 13:00 ` [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB Fiona Ebner
2025-06-01 9:51 ` Thomas Lamprecht
2025-06-02 11:21 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3307fd93-89bc-4a66-9ad2-08dac89b119b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.