all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v6 3/5] bulk migrate: include checks for live-migratable local resources
Date: Mon, 10 Mar 2025 15:40:09 +0100	[thread overview]
Message-ID: <32fea49a-33fb-4cc2-bb45-d4a8f586a960@proxmox.com> (raw)
In-Reply-To: <52d449b0-01a9-49c4-8ec1-b1b8747ea264@proxmox.com>

Am 10.03.25 um 14:58 schrieb Dominik Csapak:
> On 3/10/25 14:21, Fiona Ebner wrote:
>> Am 10.03.25 um 13:52 schrieb Dominik Csapak:
>>> hmm i can try that, but i have a question on how to handle some
>>> situations:
>>>
>>> there are the following possibilities (if I didn't forget one):
>>> * non-mapped hostpci device -> local resource
>>> * mapped hostpci device with no live migration capabilities -> local
>>> resource + mapped
>>
>> I'd only add it to local resources if $state is set too, i.e. if it is a
>> live migration. If it's mapped and if it's an offline migration, don't
>> add it.
>>
>>> * mapped hostpci device with live migration capabilities -> mapped only
>>>
>>> did I understand you correctly?
>>>
>>
>> I.e. local resources should only contain the config keys that are actual
>> blockers for the migration at hand, which differs when it's online or
>> offline.
> 
> 
> ok makes sense, did a quick test here, and it seems the UI handles it
> already gracefully,
> (we ignore the local_resources for mapped devices alread) but wouldn't
> that be a 'breaking' change,
> since we did return the devices in the 'local_resources' list until now?
> 
> I'm not saying that the change would be bad, but the current description
> and results would not
> indicate to an api user that it's only for blocking migrations, as the
> current description is
> "List local resources e.g. pci, usb"

It comes down to arguing what "local" means in this context. One could
argue that a mapped device is a logical abstraction over equivalent
devices on multiple nodes and thus not local in that sense. Looking at
the API endpoint naively, I would intuitively expect local_resources and
mapped-resources to be disjoint.

Regarding breakage, you do have a point. If a consumer is relying only
on local_resources and not looking at the mappings, or using the keys
from local resources to try to iterate over the mappings, the
precondition check would be wrong in the case of missing mappings.

IMHO we can go for this, as it's only the precondition check, migration
will just fail later for such API consumers. We can make the description
more precise, i.e. mention these are the local resources that cannot be
migrated, do not include mapped resources and they can be different for
offline vs. online.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-03-10 14:40 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 13:16 [pve-devel] [PATCH (guest-)common/qemu-server/manager/docs v6] implement Dominik Csapak
2025-02-13 13:16 ` [pve-devel] [PATCH common v6 1/1] sysfs tools: add 'nvidia' -> 'mdev' workaround to pci_device_info Dominik Csapak
2025-03-06 13:00   ` [pve-devel] applied: " Thomas Lamprecht
2025-02-13 13:16 ` [pve-devel] [PATCH guest-common v6 1/2] mapping: pci: check the mdev configuration on the device too Dominik Csapak
2025-03-07 10:52   ` Fiona Ebner
2025-02-13 13:16 ` [pve-devel] [PATCH guest-common v6 2/2] mapping: pci: add 'live-migration-capable' flag to mappings Dominik Csapak
2025-03-07 10:52   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 01/10] vm stop-cleanup: allow callers to decide error behavior Dominik Csapak
2025-03-06 16:42   ` [pve-devel] applied: " Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 02/10] migrate: call vm_stop_cleanup after stopping in phase3_cleanup Dominik Csapak
2025-03-06 16:42   ` [pve-devel] applied: " Fiona Ebner
2025-03-07 11:02     ` Dominik Csapak
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 03/10] tests: cfg2cmd: fix mdev tests Dominik Csapak
2025-03-07 11:20   ` [pve-devel] applied: " Fiona Ebner
2025-03-07 11:54     ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 04/10] pci: mapping: check mdev config against hardware Dominik Csapak
2025-03-07 11:20   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 05/10] pci: set 'enable-migration' to on for live-migration marked mapped devices Dominik Csapak
2025-03-07 11:20   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 06/10] check_local_resources: add more info per mapped device and return as hash Dominik Csapak
2025-03-07 11:20   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 07/10] api: enable live migration for marked mapped pci devices Dominik Csapak
2025-03-07 11:20   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 08/10] api: include not mapped resources for running vms in migrate preconditions Dominik Csapak
2025-03-07 12:20   ` Fiona Ebner
2025-03-07 12:56     ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 09/10] migrate: show vfio state transferred too Dominik Csapak
2025-03-07 12:35   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH qemu-server v6 10/10] migrate: add transfer summary Dominik Csapak
2025-03-07 12:35   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH manager v6 1/5] mapping: pci: include mdev in config checks Dominik Csapak
2025-03-07 13:00   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH manager v6 2/5] bulk migrate: improve precondition checks Dominik Csapak
2025-03-07 13:19   ` Fiona Ebner
2025-03-07 13:23     ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH manager v6 3/5] bulk migrate: include checks for live-migratable local resources Dominik Csapak
2025-03-07 13:30   ` Fiona Ebner
2025-03-07 13:40     ` Fiona Ebner
2025-03-10 12:52       ` Dominik Csapak
2025-03-10 13:21         ` Fiona Ebner
2025-03-10 13:58           ` Dominik Csapak
2025-03-10 14:40             ` Fiona Ebner [this message]
2025-02-13 13:17 ` [pve-devel] [PATCH manager v6 4/5] ui: adapt migration window to precondition api change Dominik Csapak
2025-03-07 14:03   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH manager v6 5/5] fix #5175: ui: allow configuring and live migration of mapped pci resources Dominik Csapak
2025-03-07 14:33   ` Fiona Ebner
2025-02-13 13:17 ` [pve-devel] [PATCH docs v6 1/2] qm: resource mapping: add description for `mdev` option Dominik Csapak
2025-02-13 13:17 ` [pve-devel] [PATCH docs v6 2/2] qm: resource mapping: document `live-migration-capable` setting Dominik Csapak
2025-02-13 13:30 ` [pve-devel] [PATCH (guest-)common/qemu-server/manager/docs v6] implement Dominik Csapak
2025-03-07 14:39 ` Fiona Ebner
2025-03-11 13:23 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32fea49a-33fb-4cc2-bb45-d4a8f586a960@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal