all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Cc: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	"Wolfgang Bumiller" <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH v2 qemu] io_uring: resubmit when result is -EAGAIN
Date: Thu, 29 Jul 2021 17:59:01 +0200	[thread overview]
Message-ID: <32e03cd7-1a0c-459f-e190-ce76e32d3c98@proxmox.com> (raw)
In-Reply-To: <20210729095031.90694-1-f.ebner@proxmox.com>

On 29/07/2021 11:50, Fabian Ebner wrote:
> Linux SCSI can throw spurious -EAGAIN in some corner cases in its
> completion path, which will end up being the result in the completed
> io_uring request.
> 
> Resubmitting such requests should allow block jobs to complete, even
> if such spurious errors are encountered.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v1:
>     * make it a patch for pve-qemu instead of the qemu submodule
>     * use v2 of the patch with a comment by Stefan Hajnoczi
> 
>  ...uring-resubmit-when-result-is-EAGAIN.patch | 49 +++++++++++++++++++
>  debian/patches/series                         |  1 +
>  2 files changed, 50 insertions(+)
>  create mode 100644 debian/patches/extra/0002-block-io_uring-resubmit-when-result-is-EAGAIN.patch
> 
>

applied, thanks!

For others regarding bump: while this is def. correct it actually increases the
likelihood of a kernel crash with old (<< pve-kernel-5.11.22-3-pve 5.11.22-6)
kernels. As now it was either a crash or a block job error, this patch basically
converts the block job errors into crashes on bad old kernel and into avoiding
a block job error on the OK behavior of resubmitting on EAGAIN on new kernels.
Those that saw neither crash nor block job errors won't notice a difference
either way.




      reply	other threads:[~2021-07-29 15:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  9:50 [pve-devel] " Fabian Ebner
2021-07-29 15:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32e03cd7-1a0c-459f-e190-ce76e32d3c98@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal