all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH widget-toolkit] fix #3919: show first task output line correctly
Date: Fri, 4 Mar 2022 14:55:36 +0100	[thread overview]
Message-ID: <32129fdd-a29d-b21d-b656-3474d7a7b7e6@proxmox.com> (raw)
In-Reply-To: <20220303141145.352761-1-d.csapak@proxmox.com>

On 03/03/2022 15:11, Dominik Csapak wrote:
> if a task did not produce output yet, we always get a single line
> with "no output". our heuristic in the gui counts the total lines +
> the current  position. so to update the first output correctly, we
> have to update every time in case we only have one line.
> 
> Otherwise, we only update on the second line, which is bad
> in case the only line we ever get is the result.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/panel/LogView.js | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2022-03-04 13:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 14:11 [pve-devel] " Dominik Csapak
2022-03-04 13:55 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32129fdd-a29d-b21d-b656-3474d7a7b7e6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal