From: Fiona Ebner <f.ebner@proxmox.com>
To: Markus Frank <m.frank@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files
Date: Fri, 2 May 2025 14:13:34 +0200 [thread overview]
Message-ID: <31df6e00-1bc0-4983-8f7e-4101604cdd50@proxmox.com> (raw)
In-Reply-To: <01768d6c-227f-4d31-93de-cc752b8ebf07@proxmox.com>
Am 02.05.25 um 13:52 schrieb Markus Frank:
> On 2025-04-28 12:17, Fiona Ebner wrote:
>> As reported in the community forum [0] and the virtio-win project [1],
>> virtiofsd will run into its open file limit when used with a Windows
>> guest that reads too many files. It's also reported that the issue
>> does not occur with Linux guests and a workaround is using
>> '--inode-file-handles=mandatory' on virtiofsd command line.
> I was able to reproduce the issue with a directory containing a million
> files.
> The virtiofs share became unusable when I tried to list the files with
> 'ls'.
> This patch allows to list all the files without problems.
>>
>> The option is described as follows in the vritiofsd help:
> typo: virtiofsd
Will fix!
>>
>>> When to use file handles to reference inodes instead of O_PATH file
>>> descriptors (never, prefer, mandatory)
>>
>> and the default is 'never'.
>>
>> Fix the above issue by using 'prefer' rather than 'mandatory', because
>> that should not break other edge cases:
>>
>>> prefer: Attempt to generate file handles, but fall back to O_PATH
>>> file descriptors where the underlying filesystem does not support
>>> file handles. Useful when there are various different filesystems
>>> under the shared directory and some of them do not support file
>>> handles.
>>
>> [0]: https://forum.proxmox.com/threads/165565/
>> [1]: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/1136
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> Tested-by: Markus Frank <m.frank@proxmox.com>
>> ---
>>
>> Didn't get around to measure the performance impact yet, so feel free
>> to check that if you test this patch. While not being broken is more
>> important than good performance, it would still be good to know for
>> completeness.
> I made a few read/write tests with fio in a Windows 11 guest.
Since the option affects file handles, it would be more interesting to
test something that involves handling many files rather than just IO.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-02 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 10:17 Fiona Ebner
2025-05-02 11:52 ` Markus Frank
2025-05-02 12:13 ` Fiona Ebner [this message]
2025-05-02 14:15 ` Markus Frank
2025-05-02 14:22 ` [pve-devel] superseded: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31df6e00-1bc0-4983-8f7e-4101604cdd50@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal