all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	John Hollowell <jhollowe@johnhollowell.com>
Subject: Re: [pve-devel] [PATCH http-server 1/1] fix #4344: http-server: ignore unused multipart headers
Date: Wed, 16 Nov 2022 11:05:34 +0100	[thread overview]
Message-ID: <307e7d4f-54dc-241a-93fb-589033442dca@proxmox.com> (raw)
In-Reply-To: <20221113234810.6642-2-jhollowe@johnhollowell.com>

(Citing the accidental off-list response)
>>
>> We should drop the xx and escaping of spaces, it's not needed for the
>> single line.
>>
> 
>  I think this would still be needed to support weird filenames? idk, I'm
> not familiar with all of perl's regex flags.

AFAIUI the /x and /xx is in case you want to use whitespace/newlines as 
separators in the regex, rather than actually matching it:
https://perldoc.perl.org/perlre#/x-and-/xx

Instead of e.g. `Disposition:\ (.*?);\ name=`
we can then use `Disposition: (.*?); name=`

>>  I'm thinking of whether it would be better to include this line in the
>> 
>> other one, or not. Probably more clearer the way it is now.
> 
> 
> I think, while this is more lines, it is a better signpost that this is the
> end of the multipart stuff. And if any future
> data needs to be taken from the headers, it will not need to change.

Agree, let's keep it that way.




      parent reply	other threads:[~2022-11-16 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13 23:48 [pve-devel] [PATCH http-server 0/1] fix #4344: " John Hollowell
2022-11-13 23:48 ` [pve-devel] [PATCH http-server 1/1] fix #4344: http-server: " John Hollowell
2022-11-14 10:33   ` Matthias Heiserer
2022-11-16 10:05   ` Matthias Heiserer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=307e7d4f-54dc-241a-93fb-589033442dca@proxmox.com \
    --to=m.heiserer@proxmox.com \
    --cc=jhollowe@johnhollowell.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal