From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-widget-toolkit 1/1] RRDChart: fix title lookup for object series
Date: Mon, 4 Aug 2025 16:22:03 +0200 [thread overview]
Message-ID: <306b4eea-400c-4290-9963-ef001ea9458e@proxmox.com> (raw)
In-Reply-To: <20250804132928.1714525-1-d.csapak@proxmox.com>
Am 04.08.25 um 15:29 schrieb Dominik Csapak:
> when we give a field(series) as an object instead of a string, we have
> to lookup the title from the object. The code was designed to do this,
> but accidentally always used the first entry in the 'fields' array
> to lookup the title if the field was not a plain string one.
>
> to fix this, simply check if the field is the one we're looking for
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this is necessary for the next patch to have correct tooltips
>
> src/panel/RRDChart.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-04 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 13:29 [pve-devel] " Dominik Csapak
2025-08-04 13:29 ` [pve-devel] [PATCH pve-manager 1/1] ui: node memory RRD: make 'Available' a line graph Dominik Csapak
2025-08-04 14:22 ` [pve-devel] applied: " Thomas Lamprecht
2025-08-04 14:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=306b4eea-400c-4290-9963-ef001ea9458e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.