From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] www: backup job detail: style fixups using proxmox-biome
Date: Mon, 14 Jul 2025 11:48:04 +0200 [thread overview]
Message-ID: <2pww7jgaaqr5tll2xi5nbwbuwbgktfgh4r63relmwd6fn2kwod@n5d3rrvx7lxx> (raw)
In-Reply-To: <20250714084553.57147-1-l.wagner@proxmox.com>
On 14.07.2025 10:45, Lukas Wagner wrote:
>Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
>---
>
>Notes:
> Mea culpa, I did not know that 'make check' does not check for
> formatting issues.
>
> www/manager6/dc/BackupJobDetail.js | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js
>index 464bb558..67ec5273 100644
>--- a/www/manager6/dc/BackupJobDetail.js
>+++ b/www/manager6/dc/BackupJobDetail.js
>@@ -215,7 +215,7 @@ Ext.define('PVE.dc.BackupInfo', {
> let mailto = record?.mailto;
> let mailnotification = record?.mailnotification ?? 'always';
>
>- if ((value === 'auto' && mailto === undefined) || (value === 'notification-system')) {
>+ if ((value === 'auto' && mailto === undefined) || value === 'notification-system') {
> return gettext('Use global notification settings');
> } else if (mailnotification === 'always') {
> return gettext('Always send email');
>@@ -395,7 +395,9 @@ Ext.define('PVE.dc.BackupInfo', {
> let notificationMode = values['notification-mode'] ?? 'auto';
> let mailto = values.mailto;
>
>- let hideRecipients = (notificationMode === 'auto' && mailto === undefined) || (notificationMode === 'notification-system');
>+ let hideRecipients =
>+ (notificationMode === 'auto' && mailto === undefined) ||
>+ notificationMode === 'notification-system';
> vm.set('hideRecipients', hideRecipients);
>
> // selection Mode depends on the presence/absence of several keys
>--
Looks good to me:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Sorry for not noticing earlier.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-14 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 8:45 Lukas Wagner
2025-07-14 9:48 ` Gabriel Goller [this message]
2025-07-15 19:52 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2pww7jgaaqr5tll2xi5nbwbuwbgktfgh4r63relmwd6fn2kwod@n5d3rrvx7lxx \
--to=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.