all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH access-control] jobs: realm sync: fix scheduled LDAP syncs not applying attributes correctly
Date: Thu, 21 Mar 2024 10:33:34 +0100	[thread overview]
Message-ID: <2nov4bdgzj52pgks7z6wb5o57wvxijb7yf2giulltwnqytlgi3@5am23h37hzy7> (raw)
In-Reply-To: <b3868fa2-2815-4afc-8e26-e9b68a4b8981@proxmox.com>

On Tue, Mar 19, 2024 at 03:57:34PM +0100, Fiona Ebner wrote:
> Am 19.03.24 um 14:48 schrieb Christoph Heiss:
> > This was reported by a user in the forum [0].
> >
> > The cause was that the user-* standard options were not registered when
> > the sync was called from the scheduler, resulting in the following
> > error:
> >
> >   pvescheduler[2849]: skipping attribute mapping 'cn'->'comment' for user 'test@samba0' - no such standard option 'user-comment'
> >
> > Fix this by simply importing the PVE::API2::User module, thus ensuring
> > the options get registered.
> >
> > [0] https://forum.proxmox.com/threads/ldap-integration-comment-email-first-name-lastname.143490/
> >
> > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
>
> Fixes: cb93636 ("LDAP sync: improve validation of synced attributes")
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> Tested-by: Fiona Ebner <f.ebner@proxmox.com>

Thanks for the review & testing!

>
> Thank you for the fix!
>
> The schema for the user- properties could also be moved somewhere that
> can be accessed by both API2::User module and Auth::LDAP module and
> included there directly. That would be more future-proof, but as a quick
> fix, this is fine too.

That was actually my approach too, and I already started working on a
series for exactly this.

But since this definitely requires some care to catch all sites and
further avoid getting it then stuck in review limbo, I thought sending a
quick fix should help this get resolved faster, for now at least. :^)




      reply	other threads:[~2024-03-21  9:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 13:48 Christoph Heiss
2024-03-19 14:57 ` Fiona Ebner
2024-03-21  9:33   ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2nov4bdgzj52pgks7z6wb5o57wvxijb7yf2giulltwnqytlgi3@5am23h37hzy7 \
    --to=c.heiss@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal