From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces
Date: Mon, 14 Nov 2022 11:07:53 +0100 [thread overview]
Message-ID: <2ff2f3db-7243-d1e8-a710-8e8ea4adddd0@proxmox.com> (raw)
In-Reply-To: <f316ee98-5711-b8db-3be4-52656a77dcba@proxmox.com>
Am 14/11/2022 um 09:26 schrieb Stefan Sterz:
>> IIUC this indirectly raised the minimum length of references to two characters,
>> not a deal breaker IMO as I don't really expect two characters to be used anytime
>> soon (maybe with unicode 🤔🧠💠x)), but maybe hint it in the commit message.
>>
> yes that is correct. just to have made the suggestion: the "[^}]" could
> be dropped here. that should get us back down to one character, but will
> also filter the necessary keys. and anchors like "{key" are just as
> invalid as "{key}" in asciidoc.
>
or move it to a single one replacing the whole non-greedy part, something like
(untested): [^{}\[\]"']+
next prev parent reply other threads:[~2022-11-14 10:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 15:05 [pve-devel] [PATCH docs v2 0/2] pve fix help buttons by accounting for keys in widget toolkit Stefan Sterz
2022-11-11 15:05 ` [pve-devel] [PATCH docs v2 1/2] pveum: add the "user_mgmt" reference to the documentation Stefan Sterz
2022-11-11 18:24 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-11 15:05 ` [pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces Stefan Sterz
2022-11-11 18:22 ` Thomas Lamprecht
2022-11-14 8:26 ` Stefan Sterz
2022-11-14 10:07 ` Thomas Lamprecht [this message]
2022-11-14 10:13 ` Stefan Sterz
2022-11-14 10:16 ` Thomas Lamprecht
2022-11-11 15:05 ` [pve-devel] [PATCH manager v2 1/1] fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js Stefan Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff2f3db-7243-d1e8-a710-8e8ea4adddd0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal