Re: [pmg-devel] [PATCH log-tracker 1/3] update tests

[Mira Limbeck <m.limbeck@proxmox.com>]

On 2/26/21 10:22 AM, Mira Limbeck wrote:
> On 2/25/21 11:56 AM, Thomas Lamprecht wrote:
>> On 19.02.21 11:31, Mira Limbeck wrote:
>>> As we only have month, day and time available but not the year, we have
>>> to update the tests every year.
>> I'm probably just missing context but why exactly is that the case?
>>
> The logs only contain month, day and time of the day which we parse. 
> We do this based on the current date and timezone.
>
> So depending on the current date and the date in the logs, we either 
> assume it to be in the past or in the future. This results in a 
> different calculated CTIME then and the tests need to be updated 
> accordingly.
Correction, we always assume it to be in the past. But without the year 
info we assume it is no older than 1 year. This means when the test 
results we check against was created before that, the CTIME does not 
match anymore now.
>
>
> Stoiko and I talked about this when I sent the patch, and we probably 
> want to switch to logging the year as well with 7.0 so these test 
> updates are no longer required afterwards.
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
>
>