all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH proxmox-i18n 0/1] update German translation
@ 2023-10-09  9:38 hd
  2023-10-09  9:38 ` [pve-devel] [PATCH proxmox-i18n 1/1] " hd
  0 siblings, 1 reply; 4+ messages in thread
From: hd @ 2023-10-09  9:38 UTC (permalink / raw)
  To: pve-devel

I suggest an update of the german translation

hd (1):
  update German translation

 de.po | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.39.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH proxmox-i18n 1/1] update German translation
  2023-10-09  9:38 [pve-devel] [PATCH proxmox-i18n 0/1] update German translation hd
@ 2023-10-09  9:38 ` hd
  2023-10-09 10:46   ` Lukas Wagner
  2023-10-09 11:11   ` Thomas Lamprecht
  0 siblings, 2 replies; 4+ messages in thread
From: hd @ 2023-10-09  9:38 UTC (permalink / raw)
  To: pve-devel

---
 de.po | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/de.po b/de.po
index fea74f1..c647f31 100644
--- a/de.po
+++ b/de.po
@@ -747,9 +747,8 @@ msgid "Authentication mode"
 msgstr "Authentifikationsmodus"
 
 #: proxmox-widget-toolkit/src/panel/SendmailEditPanel.js:111
-#, fuzzy
 msgid "Author"
-msgstr "Auth-ID"
+msgstr "Autor"
 
 #: pmg-gui/js/TFAView.js:60 pve-manager/www/manager6/dc/OptionView.js:241
 #: proxmox-backup/www/config/WebauthnView.js:109
-- 
2.39.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation
  2023-10-09  9:38 ` [pve-devel] [PATCH proxmox-i18n 1/1] " hd
@ 2023-10-09 10:46   ` Lukas Wagner
  2023-10-09 11:11   ` Thomas Lamprecht
  1 sibling, 0 replies; 4+ messages in thread
From: Lukas Wagner @ 2023-10-09 10:46 UTC (permalink / raw)
  To: Proxmox VE development discussion, hd

Hello Hannes,

please configure your git client so that the commit author is your full 
name [1]:

   git config --global user.name "Firstname Lastname"

Also, this patch is missing the 'Signed-off-by' line. That line is 
auto-generated by git if you provide the right flags to `git commit` or 
`git format-patch` (e.g. `git commit -s`, maybe create a git alias for that)

Also, for single patches there is no need to send a cover-letter.
If there is anything to be said about the patch that should *not* be
part of the commit message, you can write it under the the '---' marker.

Hope this helps :)

[1] https://pve.proxmox.com/wiki/Developer_Documentation#Using_git

On 10/9/23 11:38, hd wrote:
> ---
     ^ I mean this marker here.

>   de.po | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/de.po b/de.po
> index fea74f1..c647f31 100644
> --- a/de.po
> +++ b/de.po
> @@ -747,9 +747,8 @@ msgid "Authentication mode"
>   msgstr "Authentifikationsmodus"
>   
>   #: proxmox-widget-toolkit/src/panel/SendmailEditPanel.js:111
> -#, fuzzy
>   msgid "Author"
> -msgstr "Auth-ID"
> +msgstr "Autor"
>   
>   #: pmg-gui/js/TFAView.js:60 pve-manager/www/manager6/dc/OptionView.js:241
>   #: proxmox-backup/www/config/WebauthnView.js:109

-- 
- Lukas




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation
  2023-10-09  9:38 ` [pve-devel] [PATCH proxmox-i18n 1/1] " hd
  2023-10-09 10:46   ` Lukas Wagner
@ 2023-10-09 11:11   ` Thomas Lamprecht
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2023-10-09 11:11 UTC (permalink / raw)
  To: Proxmox VE development discussion, hd

Am 09/10/2023 um 11:38 schrieb hd:
> ---
>  de.po | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

On-top of what Lukas mentioned: there are dozens of fuzzy strings
in de.po, and applying/reviewing patches has a slight overhead
independent of the amount of changes, so I'd be great if you send
an update for a few more than just a single change in one patch,
so we get a better "return of (review/apply time) investment".




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-09 11:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-09  9:38 [pve-devel] [PATCH proxmox-i18n 0/1] update German translation hd
2023-10-09  9:38 ` [pve-devel] [PATCH proxmox-i18n 1/1] " hd
2023-10-09 10:46   ` Lukas Wagner
2023-10-09 11:11   ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal