all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models
@ 2023-06-09 10:27 Alexandre Derumier
  2023-06-19  8:46 ` Fiona Ebner
  0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Derumier @ 2023-06-09 10:27 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 PVE/QemuServer/CPUConfig.pm | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
index fb0861b..77fc682 100644
--- a/PVE/QemuServer/CPUConfig.pm
+++ b/PVE/QemuServer/CPUConfig.pm
@@ -66,16 +66,28 @@ my $cpu_vendor_list = {
     'Skylake-Client' => 'GenuineIntel',
     'Skylake-Client-IBRS' => 'GenuineIntel',
     'Skylake-Client-noTSX-IBRS' => 'GenuineIntel',
+    'Skylake-Client-v4' => 'GenuineIntel',
     'Skylake-Server' => 'GenuineIntel',
     'Skylake-Server-IBRS' => 'GenuineIntel',
     'Skylake-Server-noTSX-IBRS' => 'GenuineIntel',
+    'Skylake-Server-v4' => 'GenuineIntel',
+    'Skylake-Server-v5' => 'GenuineIntel',
     'Cascadelake-Server' => 'GenuineIntel',
     'Cascadelake-Server-noTSX' => 'GenuineIntel',
+    'Cascadelake-Server-v4' => 'GenuineIntel',
+    'Cascadelake-Server-v5' => 'GenuineIntel',
+    'CooperLake' => 'GenuineIntel',
+    'CooperLake-v2' => 'GenuineIntel',
     KnightsMill => 'GenuineIntel',
     'Icelake-Client' => 'GenuineIntel', # depreacated, removed with QEMU 7.1
     'Icelake-Client-noTSX' => 'GenuineIntel', # depreacated, removed with QEMU 7.1
     'Icelake-Server' => 'GenuineIntel',
     'Icelake-Server-noTSX' => 'GenuineIntel',
+    'Icelake-Server-v3' => 'GenuineIntel',
+    'Icelake-Server-v4' => 'GenuineIntel',
+    'Icelake-Server-v5' => 'GenuineIntel',
+    'Icelake-Server-v6' => 'GenuineIntel',
+    'SapphireRapids' => 'GenuineIntel',
 
     # AMD CPUs
     athlon => 'AuthenticAMD',
@@ -87,7 +99,9 @@ my $cpu_vendor_list = {
     Opteron_G5 => 'AuthenticAMD',
     EPYC => 'AuthenticAMD',
     'EPYC-IBPB' => 'AuthenticAMD',
+    'EPYC-v3' => 'AuthenticAMD',
     'EPYC-Rome' => 'AuthenticAMD',
+    'EPYC-Rome-v2' => 'AuthenticAMD',
     'EPYC-Milan' => 'AuthenticAMD',
 
     # generic types, use vendor from host node
-- 
2.30.2




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models
  2023-06-09 10:27 [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models Alexandre Derumier
@ 2023-06-19  8:46 ` Fiona Ebner
  2023-06-19  9:19   ` DERUMIER, Alexandre
  0 siblings, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2023-06-19  8:46 UTC (permalink / raw)
  To: Proxmox VE development discussion, Alexandre Derumier

Am 09.06.23 um 12:27 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  PVE/QemuServer/CPUConfig.pm | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
> index fb0861b..77fc682 100644
> --- a/PVE/QemuServer/CPUConfig.pm
> +++ b/PVE/QemuServer/CPUConfig.pm
> @@ -66,16 +66,28 @@ my $cpu_vendor_list = {
>      'Skylake-Client' => 'GenuineIntel',
>      'Skylake-Client-IBRS' => 'GenuineIntel',
>      'Skylake-Client-noTSX-IBRS' => 'GenuineIntel',
> +    'Skylake-Client-v4' => 'GenuineIntel',
>      'Skylake-Server' => 'GenuineIntel',
>      'Skylake-Server-IBRS' => 'GenuineIntel',
>      'Skylake-Server-noTSX-IBRS' => 'GenuineIntel',
> +    'Skylake-Server-v4' => 'GenuineIntel',
> +    'Skylake-Server-v5' => 'GenuineIntel',
>      'Cascadelake-Server' => 'GenuineIntel',
>      'Cascadelake-Server-noTSX' => 'GenuineIntel',

The above is an alias for Cascadelake-Server-v3, but -v2 is still
missing here AFAICT.

> +    'Cascadelake-Server-v4' => 'GenuineIntel',
> +    'Cascadelake-Server-v5' => 'GenuineIntel',
> +    'CooperLake' => 'GenuineIntel',
> +    'CooperLake-v2' => 'GenuineIntel',

It's Cooperlake{-v2} with a small l.

>      KnightsMill => 'GenuineIntel',
>      'Icelake-Client' => 'GenuineIntel', # depreacated, removed with QEMU 7.1
>      'Icelake-Client-noTSX' => 'GenuineIntel', # depreacated, removed with QEMU 7.1
>      'Icelake-Server' => 'GenuineIntel',
>      'Icelake-Server-noTSX' => 'GenuineIntel',
> +    'Icelake-Server-v3' => 'GenuineIntel',
> +    'Icelake-Server-v4' => 'GenuineIntel',
> +    'Icelake-Server-v5' => 'GenuineIntel',
> +    'Icelake-Server-v6' => 'GenuineIntel',
> +    'SapphireRapids' => 'GenuineIntel',
>  

I also noticed that
Denverton{-v2,-v3}
Dhyana{-v2}
Snowridge{-v2,-v3,-v4}
n270
are also missing from the list. Should we add them (maybe not n270 ;))?




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models
  2023-06-19  8:46 ` Fiona Ebner
@ 2023-06-19  9:19   ` DERUMIER, Alexandre
  2023-06-19 10:07     ` Fiona Ebner
  0 siblings, 1 reply; 4+ messages in thread
From: DERUMIER, Alexandre @ 2023-06-19  9:19 UTC (permalink / raw)
  To: pve-devel, aderumier, f.ebner

Le lundi 19 juin 2023 à 10:46 +0200, Fiona Ebner a écrit :
> Am 09.06.23 um 12:27 schrieb Alexandre Derumier:
> > Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> > ---
> >  PVE/QemuServer/CPUConfig.pm | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/PVE/QemuServer/CPUConfig.pm
> > b/PVE/QemuServer/CPUConfig.pm
> > index fb0861b..77fc682 100644
> > --- a/PVE/QemuServer/CPUConfig.pm
> > +++ b/PVE/QemuServer/CPUConfig.pm
> > @@ -66,16 +66,28 @@ my $cpu_vendor_list = {
> >      'Skylake-Client' => 'GenuineIntel',
> >      'Skylake-Client-IBRS' => 'GenuineIntel',
> >      'Skylake-Client-noTSX-IBRS' => 'GenuineIntel',
> > +    'Skylake-Client-v4' => 'GenuineIntel',
> >      'Skylake-Server' => 'GenuineIntel',
> >      'Skylake-Server-IBRS' => 'GenuineIntel',
> >      'Skylake-Server-noTSX-IBRS' => 'GenuineIntel',
> > +    'Skylake-Server-v4' => 'GenuineIntel',
> > +    'Skylake-Server-v5' => 'GenuineIntel',
> >      'Cascadelake-Server' => 'GenuineIntel',
> >      'Cascadelake-Server-noTSX' => 'GenuineIntel',
> 
> The above is an alias for Cascadelake-Server-v3, but -v2 is still
> missing here AFAICT.
ok I'll add them

> 
> > +    'Cascadelake-Server-v4' => 'GenuineIntel',
> > +    'Cascadelake-Server-v5' => 'GenuineIntel',
> > +    'CooperLake' => 'GenuineIntel',
> > +    'CooperLake-v2' => 'GenuineIntel',
> 
> It's Cooperlake{-v2} with a small l.
> 
oops, thanks,will fix it.

> >      KnightsMill => 'GenuineIntel',
> >      'Icelake-Client' => 'GenuineIntel', # depreacated, removed
> > with QEMU 7.1
> >      'Icelake-Client-noTSX' => 'GenuineIntel', # depreacated,
> > removed with QEMU 7.1
> >      'Icelake-Server' => 'GenuineIntel',
> >      'Icelake-Server-noTSX' => 'GenuineIntel',
> > +    'Icelake-Server-v3' => 'GenuineIntel',
> > +    'Icelake-Server-v4' => 'GenuineIntel',
> > +    'Icelake-Server-v5' => 'GenuineIntel',
> > +    'Icelake-Server-v6' => 'GenuineIntel',
> > +    'SapphireRapids' => 'GenuineIntel',
> >  
> 

> I also noticed that
> Denverton{-v2,-v3}
> Snowridge{-v2,-v3,-v4}

Both are atom cpu. I don't known if we want to support them ? (they
seem to support vtx, so it should work with kvm)

> Dhyana{-v2}
This is a chinese fork of epyc (without aes), I don't known if we need
to support it ?
> 
> n270
> are also missing from the list. Should we add them (maybe not n270
> ;))?
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models
  2023-06-19  9:19   ` DERUMIER, Alexandre
@ 2023-06-19 10:07     ` Fiona Ebner
  0 siblings, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2023-06-19 10:07 UTC (permalink / raw)
  To: DERUMIER, Alexandre, pve-devel, aderumier


Am 19.06.23 um 11:19 schrieb DERUMIER, Alexandre:
> Le lundi 19 juin 2023 à 10:46 +0200, Fiona Ebner a écrit :
> 
>> I also noticed that
>> Denverton{-v2,-v3}
>> Snowridge{-v2,-v3,-v4}
> 
> Both are atom cpu. I don't known if we want to support them ? (they
> seem to support vtx, so it should work with kvm)
> 
>> Dhyana{-v2}
> This is a chinese fork of epyc (without aes), I don't known if we need
> to support it ?
>>
> 

I'm also not sure, that's why I asked. Maybe better to hold off for now
and wait until somebody asks for them :)




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-19 10:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 10:27 [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models Alexandre Derumier
2023-06-19  8:46 ` Fiona Ebner
2023-06-19  9:19   ` DERUMIER, Alexandre
2023-06-19 10:07     ` Fiona Ebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal