all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* Re: [pve-devel] [PATCH pve-network 1/1] Fixed Netbox API Path
       [not found] ` <20240120175755.15745-2-007seadog@gmail.com>
@ 2024-02-20 14:20   ` Thomas Lamprecht
  0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2024-02-20 14:20 UTC (permalink / raw)
  To: Jasper Yu, pve-devel

Am 20/01/2024 um 18:57 schrieb Jasper Yu:
> ---
>  src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
> index 91010bb..666ea70 100644
> --- a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
> +++ b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
> @@ -288,7 +288,7 @@ sub get_ip_id {
>  
>  sub is_ip_gateway {
>      my ($url, $ip, $headers) = @_;
> -    my $result = PVE::Network::SDN::api_request("GET", "$url/addresses/search/$ip", $headers);
> +    my $result = PVE::Network::SDN::api_request("GET", "$url/ipam/ip-addresses/?q=$ip", $headers);
>      my $data = @{$result->{data}}[0];
>      my $description = $data->{description};
>      my $is_gateway = 1 if $description eq 'gateway';

Thanks for your patch, but it seems we do not have a signed CLA from
you and a Signed-off-by in the patch, please see:
https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright

But as Alexandre already sent a similar change, I applied [0] that
instead with an Originally-by trailer to give you some credit, I hope
that's all right with you.

[0]: https://git.proxmox.com/?p=pve-network.git;a=commitdiff;h=b18b34aad560e77ae9ea407e2154780817ba6a54




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-02-20 14:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20240120175755.15745-1-007seadog@gmail.com>
     [not found] ` <20240120175755.15745-2-007seadog@gmail.com>
2024-02-20 14:20   ` [pve-devel] [PATCH pve-network 1/1] Fixed Netbox API Path Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal