From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Jasper Yu <007seadog@gmail.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-network 1/1] Fixed Netbox API Path
Date: Tue, 20 Feb 2024 15:20:36 +0100 [thread overview]
Message-ID: <2f5574b8-5e22-4a6e-b2a4-2f4333b2d38d@proxmox.com> (raw)
In-Reply-To: <20240120175755.15745-2-007seadog@gmail.com>
Am 20/01/2024 um 18:57 schrieb Jasper Yu:
> ---
> src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
> index 91010bb..666ea70 100644
> --- a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
> +++ b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
> @@ -288,7 +288,7 @@ sub get_ip_id {
>
> sub is_ip_gateway {
> my ($url, $ip, $headers) = @_;
> - my $result = PVE::Network::SDN::api_request("GET", "$url/addresses/search/$ip", $headers);
> + my $result = PVE::Network::SDN::api_request("GET", "$url/ipam/ip-addresses/?q=$ip", $headers);
> my $data = @{$result->{data}}[0];
> my $description = $data->{description};
> my $is_gateway = 1 if $description eq 'gateway';
Thanks for your patch, but it seems we do not have a signed CLA from
you and a Signed-off-by in the patch, please see:
https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
But as Alexandre already sent a similar change, I applied [0] that
instead with an Originally-by trailer to give you some credit, I hope
that's all right with you.
[0]: https://git.proxmox.com/?p=pve-network.git;a=commitdiff;h=b18b34aad560e77ae9ea407e2154780817ba6a54
parent reply other threads:[~2024-02-20 14:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240120175755.15745-2-007seadog@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f5574b8-5e22-4a6e-b2a4-2f4333b2d38d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=007seadog@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal